[pull] master from golang:master#50
Merged
Merged
Conversation
The recent work on size-specialized malloc changed the number of frames that appear in the memory profile when allocation takes the slow path. Now, the fast path results in 4 frames, the slow path results in 5, and race builds (which disable size-specialized malloc) have 6. The test was expecting either 4 or 6. The recent test flakes were likely due to the GC running concurrently with the test, which would trigger mallocgcSmallScanNoHeaderSC4's check of gcBlackenEnabled != 0. We can confirm by running the test with GODEBUG=traceallocfree=1 and the -trace flag, which forces the slow path. Fixes #79528 Change-Id: I119d0f275e7c3527e4a12d5dc2138071679349e7 Reviewed-on: https://go-review.googlesource.com/c/go/+/781680 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Richard Miller <millerresearch@gmail.com>
CL 749981 added export linknames to assembly symbols accessed externally. socketcall and rawsocketcall on S390X were missed. Add them. Fixes #79605. Change-Id: I8497916e31bdc80a3f7b0084b3267cee9ce525b1 Reviewed-on: https://go-review.googlesource.com/c/go/+/781920 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Cherry Mui <cherryyz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )