Conversation
Fixes some issues in the examples directory that can be found by running
mypy as follows:
mypy --check-untyped-defs examples/**/*.py
* Black formatting * Native tests pass * Passes checked in (non-generated) wasm tests * Some ethereum test fixes * Reenable wasm tests * Fix mypy error * Use pytest timeout * mypy checked untyped defs in manticore.core.smtlib
ekilmer
reviewed
Jan 19, 2021
Comment on lines
+263
to
+265
| raise ExpressionError( | ||
| "You tried to use a Bool Expression as a boolean constant. Expressions could represent a set of concrete values." | ||
| ) |
Contributor
There was a problem hiding this comment.
This statement is causing issues. I've replaced it with just
Suggested change
| raise ExpressionError( | |
| "You tried to use a Bool Expression as a boolean constant. Expressions could represent a set of concrete values." | |
| ) | |
| return self |
and it seems to be passing for me natively on both Python 3.6 and 3.9 🤷
Maybe we should revert this to how it was.
ehennenfent
reviewed
Feb 2, 2021
6d3d72c to
a81f8e8
Compare
This was referenced Feb 27, 2021
ekilmer
reviewed
Mar 2, 2021
Comment on lines
+1170
to
+1175
| __xslots__: Tuple[str, ...] = ( | ||
| "_written#v", | ||
| "_concrete_cache#v", | ||
| "_length#v", | ||
| "_default#v", | ||
| ) |
Contributor
There was a problem hiding this comment.
What does the #v suffix mean here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__slots__from parent classes automatically-ish. (xslots)__subclasses__to ensure all are accounted for..... (tbc)