fix(macros): don't look for .env outside workspace#4282
Open
abonander wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@gabe-lepo @rnestler can you try this out and let me know if it fixes the bug please? |
abonander
commented
May 26, 2026
Comment on lines
+119
to
+122
| manifest_dir | ||
| .ancestors() | ||
| .take_while(|dir| dir.starts_with(workspace_root)) | ||
| .collect::<Vec<_>>() |
Collaborator
Author
There was a problem hiding this comment.
This means that if the project has a structure like this, for example:
/
├── crates/
│ ├── foo/
│ │ └── .env
│ ├── bar/
│ │ └── .env
│ └── .env
└── .env
When compiling foo we'll read /crates/foo/.env, /crates/.env and /.env in that order.
|
@abonander I can confirm its working on my end. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #4276
Is this a breaking change?
This reverts a behavior change to match previous releases, so it would be considered a bugfix and thus non-breaking.