Fix format message not returning newline (#44)

Author: koszti

singer/messages.py

@@ -292,12 +292,12 @@ def parse_message(msg):
     return None
 
 
-def format_message(message):
-    return orjson.dumps(message.asdict(), option=orjson.OPT_APPEND_NEWLINE)
+def format_message(message, option=0):
+    return orjson.dumps(message.asdict(), option=option)
 
 
 def write_message(message):
-    sys.stdout.buffer.write(format_message(message))
+    sys.stdout.buffer.write(format_message(message, option=orjson.OPT_APPEND_NEWLINE))
     sys.stdout.buffer.flush()
 
 

tests/test_singer.py

@@ -192,6 +192,20 @@ def test_parse_bulk_decs(self):
             value = self.create_record(value_str)
             self.assertEqual(float(value_str), value)
 
+    def test_format_message(self):
+        record_message = singer.RecordMessage(
+            record={'name': 'foo'},
+            stream='users')
+
+        self.assertEqual(b'{"type":"RECORD","stream":"users","record":{"name":"foo"}}',
+                         singer.format_message(record_message))
+
+        self.assertEqual(b'{"type":"RECORD","stream":"users","record":{"name":"foo"}}',
+                         singer.format_message(record_message, option=0))
+
+        self.assertEqual(b'{"type":"RECORD","stream":"users","record":{"name":"foo"}}\n',
+                         singer.format_message(record_message, option=orjson.OPT_APPEND_NEWLINE))
+
 
 if __name__ == '__main__':
     unittest.main()