ESM-only, and refresh monolib dependencies#129
Merged
Merged
Conversation
ce6158a to
df06cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We can use this dependency refresh as the major-release moment where monolib becomes ESM-only. That lets @transloadit/format-duration-ms move to the current pretty-ms release instead of holding back on the last CommonJS-compatible major, and it keeps the whole internal dependency graph consistent.
What:
type: module.exportsfor published packages while keeping source files on relative.tsimports via TypeScriptrewriteRelativeImportExtensions.noImplicitOverride,noImplicitReturns, andnoFallthroughCasesInSwitch.substr()usage withslice().Breaking change:
import().Validation: