harden builtin template mapping

Author: kvz

packages/mcp-server/src/server.ts

@@ -412,13 +412,11 @@ const extractTemplateSteps = (content: unknown): Record<string, unknown> | undef
 }
 
 const mapBuiltinTemplate = (template: ApiTemplateRecord): BuiltinTemplate | undefined => {
-  const slug = isNonEmptyString(template.name)
-    ? template.name
-    : isNonEmptyString(template.id)
-      ? template.id
-      : undefined
+  const name = isNonEmptyString(template.name) ? template.name : undefined
+  const id = isNonEmptyString(template.id) ? template.id : undefined
+  const slug = name?.startsWith('builtin/') ? name : id?.startsWith('builtin/') ? id : undefined
 
-  if (!slug || !slug.startsWith('builtin/')) return undefined
+  if (!slug) return undefined
 
   const steps = extractTemplateSteps(template.content)
   if (!steps) return undefined
@@ -438,6 +436,7 @@ const mapBuiltinTemplate = (template: ApiTemplateRecord): BuiltinTemplate | unde
 }
 
 const fetchBuiltinTemplates = async (client: Transloadit): Promise<BuiltinTemplate[]> => {
+  // NOTE: Builtin templates are curated; we intentionally fetch the first page only for now.
   const response = await client.listTemplates({
     include_builtin: 'exclusively-latest',
     page: 1,
@@ -478,6 +477,7 @@ export const createTransloaditMcpServer = (
     version: options.serverVersion ?? packageJson.version,
   })
 
+  // Builtin templates supersede the old golden template tool; no legacy alias by design.
   server.registerTool(
     'transloadit_lint_assembly_instructions',
     {
@@ -835,3 +835,8 @@ export const createTransloaditMcpServer = (
 
   return server
 }
+
+// Expose tiny internals for unit tests only.
+export const __test__ = {
+  mapBuiltinTemplate,
+}

packages/mcp-server/test/unit/builtin-templates.test.ts

@@ -0,0 +1,21 @@
+import { describe, expect, it } from 'vitest'
+import { __test__ } from '../../src/server.ts'
+
+describe('mapBuiltinTemplate', () => {
+  it('falls back to id when name is not a builtin slug', () => {
+    const result = __test__.mapBuiltinTemplate({
+      id: 'builtin/encode-hls-video@0.0.1',
+      name: 'Encode HLS',
+      description: 'A test template',
+      content: {
+        steps: {
+          ':original': { robot: '/upload/handle' },
+        },
+      },
+    })
+
+    expect(result).toBeDefined()
+    expect(result?.slug).toBe('builtin/encode-hls-video@0.0.1')
+    expect(result?.version).toBe('0.0.1')
+  })
+})

packages/node/src/Transloadit.ts

@@ -69,6 +69,7 @@ export {
 export type { AssemblyStatus } from './alphalib/types/assemblyStatus.ts'
 export * from './apiTypes.ts'
 export { InconsistentResponseError, ApiError }
+// Builtin templates replace the legacy golden template helpers.
 export { mergeTemplateContent } from './alphalib/templateMerge.ts'
 export type {
   Base64Strategy,

packages/node/src/apiTypes.ts

@@ -109,6 +109,7 @@ interface TemplateResponseBase {
 }
 
 export interface ListedTemplate extends TemplateResponseBase {
+  // API responses may omit or null these fields for builtin or legacy templates.
   encryption_version?: number | null
   last_used?: string | null
   created?: string | null