fix: guard zod sync patching

Author: kvz

.changeset/config.json

@@ -7,7 +7,7 @@
     }
   ],
   "commit": false,
-  "fixed": [["@transloadit/node", "transloadit", "@transloadit/types"]],
+  "fixed": [["@transloadit/node", "transloadit", "@transloadit/types", "@transloadit/zod"]],
   "linked": [],
   "access": "public",
   "baseBranch": "main",

.github/workflows/ci.yml

@@ -76,6 +76,9 @@ jobs:
           node-version: ${{ matrix.node }}
       - run: corepack yarn
       - run: corepack yarn test:unit
+        if: matrix.node == 24
+      - run: corepack yarn workspace @transloadit/node test:unit
+        if: matrix.node != 24
       - name: Upload coverage reports artifact
         if: matrix.node == 24
         uses: actions/upload-artifact@v4

packages/zod/package.json

@@ -32,7 +32,7 @@
     "sync:v4": "node --experimental-strip-types scripts/sync-v4.ts",
     "sync": "yarn sync:v3 && yarn sync:v4",
     "lint:ts": "yarn sync && tsc --build tsconfig.build.json",
-    "test:unit": "node --experimental-strip-types test/scripts-config.test.ts && node --experimental-strip-types test/exports-sync.test.ts && node --experimental-strip-types test/runtime-parity.test.ts",
+    "test:unit": "node --experimental-strip-types test/scripts-config.test.ts && node --experimental-strip-types test/patch-ai-chat-schema.test.ts && node --experimental-strip-types test/exports-sync.test.ts && node --experimental-strip-types test/runtime-parity.test.ts",
     "build": "yarn sync && tsc --build tsconfig.build.json",
     "check": "yarn sync && tsc --build tsconfig.build.json && tsc --noEmit --project tsconfig.test.json && yarn test:unit"
   },

packages/zod/scripts/sync-v4.ts

@@ -1,3 +1,4 @@
+import { realpathSync } from 'node:fs'
 import { cp, mkdir, readdir, readFile, rm, writeFile } from 'node:fs/promises'
 import { dirname, resolve, sep } from 'node:path'
 import { fileURLToPath } from 'node:url'
@@ -325,10 +326,34 @@ const patchInterpolatableRobot = (contents: string): string => {
   return `${contents.slice(0, start)}${replacement}${contents.slice(end)}`
 }
 
-const patchAiChatSchema = (contents: string): string =>
-  contents
-    .replace('const jsonValueSchema: z.ZodType =', 'const jsonValueSchema: z.ZodType<any> =')
-    .replace('result: z.unknown(),', 'result: z.unknown().optional(),')
+export const patchAiChatSchema = (contents: string): string => {
+  const jsonValueToken = 'const jsonValueSchema: z.ZodType ='
+  const jsonValuePatched = 'const jsonValueSchema: z.ZodType<any> ='
+  const resultToken = 'result: z.unknown(),'
+  const resultPatched = 'result: z.unknown().optional(),'
+
+  let next = contents
+  if (next.includes(jsonValueToken)) {
+    next = next.replace(jsonValueToken, jsonValuePatched)
+  }
+  if (next.includes(resultToken)) {
+    next = next.replace(resultToken, resultPatched)
+  }
+
+  const hasJsonValue = next.includes(jsonValuePatched)
+  const hasResult = next.includes(resultPatched)
+  if (!hasJsonValue || !hasResult) {
+    const missing = [
+      !hasJsonValue ? 'jsonValueSchema' : null,
+      !hasResult ? 'result optional' : null,
+    ]
+      .filter(Boolean)
+      .join(', ')
+    throw new Error(`ai-chat schema patch failed (${missing})`)
+  }
+
+  return next
+}
 
 const patchFile = (filePath: string, contents: string): string => {
   let next = contents
@@ -360,4 +385,17 @@ const main = async () => {
   }
 }
 
-await main()
+const shouldRun = (): boolean => {
+  if (!process.argv[1]) return false
+  try {
+    const current = realpathSync(fileURLToPath(import.meta.url))
+    const invoked = realpathSync(process.argv[1])
+    return current === invoked
+  } catch {
+    return false
+  }
+}
+
+if (shouldRun()) {
+  await main()
+}

packages/zod/test/patch-ai-chat-schema.test.ts

@@ -0,0 +1,37 @@
+import assert from 'node:assert/strict'
+import { patchAiChatSchema } from '../scripts/sync-v4.ts'
+
+const source = `
+const jsonValueSchema: z.ZodType =
+  z.union([z.string()])
+
+const responseSchema = z.object({
+  result: z.unknown(),
+})
+`
+
+const patched = patchAiChatSchema(source)
+assert.ok(
+  patched.includes('const jsonValueSchema: z.ZodType<any> ='),
+  'should widen jsonValueSchema to ZodType<any>',
+)
+assert.ok(patched.includes('result: z.unknown().optional(),'), 'should make result optional')
+
+const alreadyPatched = `
+const jsonValueSchema: z.ZodType<any> =
+  z.union([z.string()])
+
+const responseSchema = z.object({
+  result: z.unknown().optional(),
+})
+`
+
+assert.equal(
+  patchAiChatSchema(alreadyPatched),
+  alreadyPatched,
+  'should be a no-op when already patched',
+)
+
+assert.throws(() => patchAiChatSchema('const jsonValueSchema: z.ZodType = z.string()'), /ai-chat/i)
+
+console.log('ai-chat schema patching: ok')