-eslint

Author: kvz

.github/workflows/ci.yml

@@ -9,16 +9,6 @@ on:
       - '*'
 
 jobs:
-  eslint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 22
-      - run: corepack yarn
-      - run: corepack yarn lint:js
-
   pack:
     runs-on: ubuntu-latest
     steps:
@@ -96,7 +86,6 @@ jobs:
   release:
     runs-on: ubuntu-latest
     needs:
-      - eslint
       - pack
       - biome
       - typescript

examples/credentials.ts

@@ -1,4 +1,3 @@
-/* eslint-disable max-len */
 // Run this file as:
 //
 //   env TRANSLOADIT_KEY=xxx TRANSLOADIT_SECRET=yyy node template_api.js

examples/fetch_costs_of_all_assemblies_in_timeframe.ts

@@ -38,7 +38,6 @@ do {
 
   await pMap(
     items,
-    // eslint-disable-next-line no-loop-func
     async (assembly) => {
       const assemblyFull = await transloadit.getAssembly(assembly.id)
       // console.log(assemblyFull.assembly_id)

src/PaginationStream.ts

@@ -1,7 +1,6 @@
 import { Readable } from 'node:stream'
 import type { PaginationList, PaginationListWithCount } from './apiTypes.js'
 
-// eslint-disable-next-line no-unused-vars
 type FetchPage<T> = (
   pageno: number,
 ) =>

src/Transloadit.ts

@@ -258,7 +258,6 @@ export class Transloadit {
 
       await pMap(
         Object.entries(files),
-        // eslint-disable-next-line no-bitwise
         async ([, path]) => access(path, constants.F_OK | constants.R_OK),
         { concurrency: 5 },
       )
@@ -357,7 +356,6 @@ export class Transloadit {
   ): Promise<AssemblyStatus> {
     assert.ok(assemblyId)
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       const result = await this.getAssembly(assemblyId)
 
@@ -401,7 +399,6 @@ export class Transloadit {
       throw err
     }
 
-    // eslint-disable-next-line no-console
     console.error(
       `---\nPlease report this error to Transloadit (support@transloadit.com). We are working on better schemas for our API and this looks like something we do not cover yet: \n\n${err}\nThank you in advance!\n---\n`,
     )
@@ -813,7 +810,6 @@ export class Transloadit {
   }
 
   // We want to mock this method
-  // eslint-disable-next-line class-methods-use-this
   private _getExpiresDate(): string {
     const expiresDate = new Date()
     expiresDate.setDate(expiresDate.getDate() + 1)

src/alphalib/zodParseWithContext.ts

@@ -43,7 +43,6 @@ export function zodParseWithContext<T extends z.ZodType>(
       Object.keys(obj).length === 0 &&
       zodRes.error.errors.length > 0
     ) {
-      // eslint-disable-next-line no-console
       // console.log('[zodParseWithContext] Empty object detected, Zod errors:', JSON.stringify(zodRes.error.errors, null, 2));
 
       const firstError = zodRes.error.errors[0]
@@ -232,7 +231,6 @@ export function zodParseWithContext<T extends z.ZodType>(
         switch (zodIssue.code) {
           case 'invalid_type': {
             received = zodIssue.received === 'undefined' ? 'missing' : zodIssue.received
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
             const actualValue = getByPath(obj, path) as any
             const actualValueStr =
               typeof actualValue === 'object' && actualValue !== null

test/integration/live-api.test.ts

@@ -481,7 +481,6 @@ describe('API integration', { timeout: 60000 }, () => {
             const ret = await client.awaitAssemblyCompletion(nn(id, 'assembly_id'))
             return ret
           } catch (err) {
-            // eslint-disable-next-line no-console
             console.error(err)
             return null
           }

test/testserver.ts

@@ -82,7 +82,6 @@ export async function createTestServer(onRequest: RequestListener) {
 
     log('Waiting for tunnel to allow requests to pass through')
 
-    // eslint-disable-next-line no-inner-declarations
     async function sendTunnelRequest() {
       // try connecting to the tunnel and resolve when connection successfully passed through
       for (let i = 0; i < 10; i += 1) {

test/util.ts

@@ -1,13 +1,11 @@
 import { RequestError, type Transloadit } from '../src/Transloadit.js'
 
-// eslint-disable-next-line import/prefer-default-export
 export const createProxy = (transloaditInstance: Transloadit) => {
   return new Proxy(transloaditInstance, {
     get(target, propKey) {
       // @ts-expect-error I dunno how to type
       const origMethod = target[propKey]
       if (typeof origMethod === 'function') {
-        // eslint-disable-next-line func-names
         return (...args: unknown[]) => {
           const result = origMethod.apply(target, args)
 

vitest.config.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineConfig } from 'vitest/config'
 
 export default defineConfig({