Skip to content

Commit 1f379dc

Browse files
committed
Remove host/region overrides from E2E flow
1 parent bee4edb commit 1f379dc

File tree

4 files changed

+3
-26
lines changed

4 files changed

+3
-26
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,6 @@ jobs:
116116
- name: Install Poetry
117117
run: pip install --upgrade poetry
118118

119-
- name: Export optional Transloadit overrides
120-
run: |
121-
if [ -n "${{ secrets.TRANSLOADIT_HOST }}" ]; then
122-
echo "TRANSLOADIT_HOST=${{ secrets.TRANSLOADIT_HOST }}" >> "$GITHUB_ENV"
123-
fi
124-
if [ -n "${{ secrets.TRANSLOADIT_REGION }}" ]; then
125-
echo "TRANSLOADIT_REGION=${{ secrets.TRANSLOADIT_REGION }}" >> "$GITHUB_ENV"
126-
fi
127-
128119
- name: Install dependencies
129120
run: poetry install
130121

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ To exercise the optional end-to-end upload against a real Transloadit account, p
7070
PYTHON_SDK_E2E=1 scripts/test-in-docker.sh --python 3.12 -- pytest tests/test_e2e_upload.py
7171
```
7272

73-
The test uploads `chameleon.jpg`, resizes it, and asserts on the live assembly results. It respects `TRANSLOADIT_HOST` and `TRANSLOADIT_REGION` overrides when present.
73+
The test uploads `chameleon.jpg`, resizes it, and asserts on the live assembly results.
7474

7575
If you have a global installation of `poetry`, you can run the tests with:
7676

scripts/test-in-docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ run_for_version() {
158158
docker_args+=(--env-file "$PWD/.env")
159159
fi
160160

161-
local -a passthrough_envs=(TRANSLOADIT_KEY TRANSLOADIT_SECRET TRANSLOADIT_HOST TRANSLOADIT_REGION TRANSLOADIT_TEMPLATE_ID PYTHON_SDK_E2E)
161+
local -a passthrough_envs=(TRANSLOADIT_KEY TRANSLOADIT_SECRET TRANSLOADIT_TEMPLATE_ID PYTHON_SDK_E2E)
162162
for var in "${passthrough_envs[@]}"; do
163163
if [[ -n "${!var:-}" ]]; then
164164
docker_args+=(-e "$var=${!var}")

tests/test_e2e_upload.py

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,6 @@ def _is_enabled():
1717
]
1818

1919

20-
def _build_service():
21-
service = os.getenv("TRANSLOADIT_HOST")
22-
if service:
23-
return service
24-
25-
region = os.getenv("TRANSLOADIT_REGION")
26-
if region:
27-
return f"https://api2-{region}.transloadit.com"
28-
29-
return None
30-
31-
3220
def test_e2e_image_resize():
3321
key = os.getenv("TRANSLOADIT_KEY")
3422
secret = os.getenv("TRANSLOADIT_SECRET")
@@ -40,9 +28,7 @@ def test_e2e_image_resize():
4028
if not fixture_path.exists():
4129
pytest.skip("chameleon.jpg fixture missing; run from repository root")
4230

43-
service = _build_service()
44-
client_kwargs = {"service": service} if service else {}
45-
client = Transloadit(key, secret, **client_kwargs)
31+
client = Transloadit(key, secret)
4632

4733
assembly = client.new_assembly()
4834

0 commit comments

Comments
 (0)