Skip to content

Commit bee4edb

Browse files
committed
Use standard key secrets for CI E2E job
1 parent 05c613c commit bee4edb

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ jobs:
9595
needs: python
9696
env:
9797
PYTHON_SDK_E2E: "1"
98-
TRANSLOADIT_KEY: ${{ secrets.TRANSLOADIT_E2E_KEY }}
99-
TRANSLOADIT_SECRET: ${{ secrets.TRANSLOADIT_E2E_SECRET }}
98+
TRANSLOADIT_KEY: ${{ secrets.TRANSLOADIT_KEY }}
99+
TRANSLOADIT_SECRET: ${{ secrets.TRANSLOADIT_SECRET }}
100100
steps:
101101
- uses: actions/checkout@v4
102102

@@ -118,11 +118,11 @@ jobs:
118118

119119
- name: Export optional Transloadit overrides
120120
run: |
121-
if [ -n "${{ secrets.TRANSLOADIT_E2E_HOST }}" ]; then
122-
echo "TRANSLOADIT_HOST=${{ secrets.TRANSLOADIT_E2E_HOST }}" >> "$GITHUB_ENV"
121+
if [ -n "${{ secrets.TRANSLOADIT_HOST }}" ]; then
122+
echo "TRANSLOADIT_HOST=${{ secrets.TRANSLOADIT_HOST }}" >> "$GITHUB_ENV"
123123
fi
124-
if [ -n "${{ secrets.TRANSLOADIT_E2E_REGION }}" ]; then
125-
echo "TRANSLOADIT_REGION=${{ secrets.TRANSLOADIT_E2E_REGION }}" >> "$GITHUB_ENV"
124+
if [ -n "${{ secrets.TRANSLOADIT_REGION }}" ]; then
125+
echo "TRANSLOADIT_REGION=${{ secrets.TRANSLOADIT_REGION }}" >> "$GITHUB_ENV"
126126
fi
127127
128128
- name: Install dependencies
@@ -131,7 +131,7 @@ jobs:
131131
- name: Ensure credentials present
132132
run: |
133133
if [ -z "$TRANSLOADIT_KEY" ] || [ -z "$TRANSLOADIT_SECRET" ]; then
134-
echo "TRANSLOADIT_E2E_KEY/TRANSLOADIT_E2E_SECRET secrets must be configured for the E2E job" >&2
134+
echo "TRANSLOADIT_KEY and TRANSLOADIT_SECRET secrets must be configured for the E2E job" >&2
135135
exit 1
136136
fi
137137

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ This script will:
6060
- install Poetry, Node.js 20, and the Transloadit CLI
6161
- pass credentials from `.env` (if present) so end-to-end tests can run against real Transloadit accounts
6262

63-
Signature parity tests use `npx transloadit smart_sig` under the hood, matching the reference implementation used by our other SDKs. Our GitHub Actions workflow also runs the E2E upload against Python 3.12 on every push/PR using a dedicated Transloadit test account.
63+
Signature parity tests use `npx transloadit smart_sig` under the hood, matching the reference implementation used by our other SDKs. Our GitHub Actions workflow also runs the E2E upload against Python 3.12 on every push/PR using a dedicated Transloadit test account (wired through the `TRANSLOADIT_KEY` and `TRANSLOADIT_SECRET` secrets).
6464

6565
Pass `--python 3.12` (or set `PYTHON_VERSIONS`) to restrict the matrix, or append a custom command after `--`, for example `scripts/test-in-docker.sh -- pytest -k smartcdn`.
6666

0 commit comments

Comments
 (0)