Generate subtree inclusion proofs with cmd/proofgen#238
Merged
Conversation
f930be2 to
bda39b0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
===========================================
- Coverage 58.55% 48.40% -10.15%
===========================================
Files 8 8
Lines 649 785 +136
===========================================
Hits 380 380
- Misses 261 397 +136
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
reviewed
Jun 18, 2026
| shift := bitCeil(p.End - p.Start) | ||
| desc := p.Desc + " - subtree" | ||
| leafIdx := p.LeafIdx | ||
| if leafIdx < ^uint64(0) { |
Collaborator
There was a problem hiding this comment.
math.MaxUint64 might be clearer?
But I'm also not super sure what this is guarding against, this condition is always true unless leafIdx == MaxUint64, but if leafIdx >= MaxUint64-shift then it's going to overflow anyway?
Am I misunderstanding/missing something?
Contributor
Author
There was a problem hiding this comment.
Done, with tighter checks. This is because some of the test use boundaries values, and we don't want to shift these.
90acf8a to
3cbfd6c
Compare
3cbfd6c to
0e03927
Compare
AlCutter
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #225.
This PR gives the ability to
cmd/proofgen.goto generatetestdata/subtreeinclusionjson files, like it generates othertestdata/files.I was not aware that this cmd was in this repo, and generated the proofs manually back then.
This is also a good opportunity to fix the description of some of these probes, which was erroneous.