[POSIX] Clean up temp files in error cases#1020
Open
mhutchinson wants to merge 1 commit into
Open
Conversation
mhutchinson
force-pushed
the
fix/posix-potential-leaks
branch
from
0201c60 to
0dbf118
Compare
AlCutter
reviewed
Jun 25, 2026
Comment on lines
+198
to
215
| tmpName := name | ||
| success := false | ||
| defer func() { | ||
| if !success { | ||
| if err := os.Remove(tmpName); err != nil { | ||
| slog.WarnContext(context.Background(), "Failed to remove temporary file", slog.String("tmpname", tmpName), slog.Any("error", err)) | ||
| } | ||
| name = "" | ||
| } | ||
| }() | ||
| defer func() { | ||
| if errC := f.Close(); errC != nil && err == nil { | ||
| err = errC | ||
| if errC := f.Close(); errC != nil { | ||
| if err == nil { | ||
| err = errC | ||
| } | ||
| success = false | ||
| } | ||
| }() |
Collaborator
There was a problem hiding this comment.
This sorta looks like it's going to defeat the point of the createTemp function by deleting the file it just created?
Note that the comment on the func says it's on the caller to remove the temporary file once they've finished with it.
Maybe you could have createTemp return a "cleanup" func which the caller can use?
| if err != nil { | ||
| return fmt.Errorf("failed to create temp file: %w", err) | ||
| } | ||
| success := false |
Collaborator
There was a problem hiding this comment.
I wonder if this would be cleaner if you named the error in the func signature and just check for err != nil in the deferred func - that's a pattern I've seen used for this sort of thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.