Harden tickets#1022
Merged
Merged
Conversation
AlCutter
force-pushed
the
harden_tickets
branch
4 times, most recently
from
01fb664 to
62e0d92
Compare
roger2hk
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens the tickets used in the
tlog-mirrorlifecycle using an HMAC to authenticate them and protect against modification.Each {mirror,log} combination uses its own HMAC key, reducing the risk of confusion from tickets from other services or mirrored logs being presented. This binding is done using HKDF.
Currently, we create an ephemeral key seed at each restart. This is fine for now (clients will just need to refresh tickets if the service restarts), but we will need to add support for a configurable fixed seed if we want to support running multiple frontends for non-POSIX storage implementations.
Towards #945