Address PR review feedback: delete .bak files, simplify assertions, use isEmpty() for collections

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Author: Copilot

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/storage/files/utils/FileStreamTest.java

@@ -61,7 +61,7 @@ void truncateTop() throws IOException {
 
     // Truncate all available data
     stream.truncateTop(3);
-    assertThat(stream.size()).isEqualTo(0);
+    assertThat(stream).isEmpty();
     assertThat(readString(temporaryFile)).isEqualTo("");
 
     stream.close();

jfr-connection/src/test/java/io/opentelemetry/contrib/jfr/connection/FlightRecorderDiagnosticCommandConnectionTest.java.bak

@@ -69,7 +69,7 @@ void mapConfiguration() {
     RecordingConfiguration recordingConfiguration = new MapConfiguration(recordingConfigAsMap);
 
     IItemCollection recordingContent = excecuteRecordingWithConfig(recordingConfiguration);
-    assertThat(recordingContent).as("excecuteRecordingWithConfig returned null").isNotNull();
+    assertThat(recordingContent).isNotNull();
     assertThat(containsEvent(recordingContent, "jdk.ObjectAllocationInNewTLAB")).isTrue();
     assertThat(containsEvent(recordingContent, "jdk.ObjectAllocationOutsideTLAB")).isTrue();
   }

jfr-connection/src/test/java/io/opentelemetry/contrib/jfr/connection/OpenDataUtilsTest.java.bak

@@ -34,7 +34,7 @@ void serialize() {
   void serializeEmptyData() {
     byte[] actual = testSubject.serialize("test-topic", Collections.emptySet());
 
-    assertThat(actual.length).isEqualTo(0);
+    assertThat(actual).isEmpty();
   }
 
   @Test