Update aws-xray module to follow style guide#127
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Update aws-xray module to follow style guide
Update aws-xray module to follow style guide
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the AWS X-Ray module to align with the project's style guide requirements, focusing on minimal changes to improve code consistency and maintainability.
Changes Made
Test Class Visibility
ResourceHolderTestclass and itstestCustomized()method frompublicto package-protected, following the style guide recommendation that "Test classes and test methods should generally be package-protected (no explicit visibility modifier) rather thanpublic"Static Imports
Added static imports for commonly used constants as recommended by the style guide:
TimeUnit constants in main classes:
AwsXrayRemoteSampler.java: Added static imports forSECONDSandNANOSECONDSAwsXrayRemoteSamplerBuilder.java: Added static imports forSECONDSandNANOSECONDSAwsXrayIdGenerator.java: Added static import forMILLISECONDSCollections utilities in test classes:
AlwaysRecordSamplerTest.java: Added static import foremptyListXrayRulesSamplerTest.java: Added static imports foremptyList,emptyMap, andsingletonMapImpact
The changes are surgical and minimal, touching only what's necessary to bring the module into compliance with the style guide.
Fixes #126.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.