Update azure-resources module to follow style guide#135
Closed
Update azure-resources module to follow style guide#135
Conversation
- Fix build.gradle.kts file (was showing GCP content) - Add AutoService dependencies - Add @autoservice annotations to SPI provider classes - Remove manual META-INF/services files - Make classes final where appropriate - Reorder class members according to style guide - Fix compilation issues and ensure all tests pass Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update azure-resources module to follow style guide
Update azure-resources module to follow style guide
Aug 24, 2025
trask
reviewed
Aug 24, 2025
| } | ||
|
|
||
| private static class Builder { | ||
| private static final class Builder { |
Author
There was a problem hiding this comment.
This change makes the nested Builder class final to comply with the style guide requirement that classes should be marked final when they are not intended to be extended. The Builder class is an internal implementation detail that doesn't need to support inheritance.
| public final class AzureVmResourceProvider extends CloudResourceProvider { | ||
|
|
||
| static class Entry { | ||
| static final class Entry { |
Author
There was a problem hiding this comment.
Added final to comply with the style guide requirement that classes should be marked final when they are not intended to be extended. The Entry class is a simple data holder that doesn't need to support inheritance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the azure-resources module to comply with the project's style guide requirements, making minimal surgical changes to bring it into alignment.
Key Changes Made
AutoService Convention
@AutoServiceannotations to all SPI provider classes (AzureVmResourceProvider,AzureFunctionsResourceProvider,AzureAppServiceResourceProvider,AzureResourceDetector)Class Structure & Finality
finalas they are public API classesfinalwhere appropriate (e.g.,Entryclass,Builderclass)Build Configuration Fix
Code Organization
Verification
The changes maintain full backward compatibility while bringing the module into compliance with the established style guide conventions.
Fixes #133.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.