Skip to content

[WIP] Update jfr-connection module to follow style guide#209

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-204
Closed

[WIP] Update jfr-connection module to follow style guide#209
Copilot wants to merge 1 commit intomainfrom
copilot/fix-204

Conversation

Copy link
Copy Markdown

Copilot AI commented Aug 24, 2025

This PR updates the jfr-connection module to follow the OpenTelemetry Java Contrib style guide (docs/style-guide.md).

Analysis completed:

  • Examine all Java files in the jfr-connection module
  • Review style guide requirements systematically
  • Identify violations to fix

Issues found and planned fixes:

  • @nonnull annotation usage: RecordingOptions.java uses @Nonnull instead of @Nullable - should use consistent javax.annotation.Nullable
  • Class finality: Several public classes should be declared final where possible
  • Static imports: Test files should use static imports for commonly used AssertJ and test methods
  • Test class visibility: Test classes should be package-protected (remove public modifiers if present)
  • Class organization: Verify proper ordering of class members (static fields, instance fields, constructors, methods, nested classes)

Next steps:

  • Implement static imports in test files
  • Add final modifiers to appropriate public classes
  • Fix annotation consistency
  • Verify class organization follows style guide
  • Run tests and formatting to ensure changes are minimal and correct

Fixes #204.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update jfr-connection module to follow style guide

2 participants