Skip to content

[WIP] Update samplers module to follow style guide#232

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-228
Closed

[WIP] Update samplers module to follow style guide#232
Copilot wants to merge 1 commit intomainfrom
copilot/fix-228

Conversation

Copy link
Copy Markdown

Copilot AI commented Aug 24, 2025

Update samplers module to follow style guide

Analysis of the samplers module against the style guide requirements:

  • Analyze existing code structure and identify style guide violations
  • Verify that tests pass and build is successful
  • Confirm errorprone conventions are already applied via otel.java-conventions plugin
  • Check formatting with spotless (no issues found)
  • Verify test classes are package-protected (already compliant)

Style Guide Issues Identified:

  • LinksParentAlwaysOnSamplerProvider: Missing @AutoService annotation and should be final
  • Missing static imports: Some static imports could be added for better consistency (requireNonNull is correctly static imported)
  • Field ordering: Verify all classes follow preferred field ordering (static final, instance final, etc.)

Minimal Changes Required:

  • Add @AutoService annotation to LinksParentAlwaysOnSamplerProvider
  • Make LinksParentAlwaysOnSamplerProvider final
  • Review and verify field/method ordering in all classes
  • Run spotlessApply to ensure formatting compliance
  • Verify tests still pass after changes

Fixes #228.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update samplers module to follow style guide

2 participants