Skip to content

Commit 13dff82

Browse files
authored
Review fixes for jsf-myfaces-3.0:javaagent (open-telemetry#17480)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 360d17f commit 13dff82

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

instrumentation/jsf/jsf-myfaces-3.0/javaagent/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ otelJava {
1717
}
1818

1919
dependencies {
20-
// can't use library for now because 6.1.0-M1 is latest and its POM referes to a missing parent POM
20+
// can't use library for now because 6.1.0-M1 is latest and its POM refers to a missing parent POM
2121
// switch back to library when a new version is released
2222
// library("jakarta.el:jakarta.el-api:4.0.0")
2323
compileOnly("jakarta.el:jakarta.el-api:4.0.0")

instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/v3_0/MyFacesInstrumentationModule.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ public MyFacesInstrumentationModule() {
2424

2525
@Override
2626
public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
27-
// jakarta.faces was introduced in JSF 3.0, replacing javax.faces
28-
return hasClassesNamed("jakarta.faces.context.FacesContext");
27+
return hasClassesNamed(
28+
// added in 3.0
29+
"jakarta.faces.context.FacesContext");
2930
}
3031

3132
@Override

0 commit comments

Comments
 (0)