Skip to content

Commit 243a888

Browse files
authored
Review fixes for testing-apps:testing-webapp (open-telemetry#18119)
1 parent eda0760 commit 243a888

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

instrumentation/jmx-metrics/testing-apps/testing-webapp/src/main/java/io/opentelemetry/instrumentation/jmx/testapp/JakartaSimpleServlet.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import jakarta.servlet.http.HttpServletRequest;
1111
import jakarta.servlet.http.HttpServletResponse;
1212
import java.io.IOException;
13-
import java.io.PrintWriter;
1413

1514
@WebServlet(urlPatterns = "/jakarta/*", name = "jakartaServlet")
1615
public class JakartaSimpleServlet extends HttpServlet {
@@ -19,8 +18,6 @@ public class JakartaSimpleServlet extends HttpServlet {
1918

2019
@Override
2120
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
22-
try (PrintWriter out = resp.getWriter()) {
23-
out.write("hello!");
24-
}
21+
resp.getWriter().write("hello!");
2522
}
2623
}

instrumentation/jmx-metrics/testing-apps/testing-webapp/src/main/java/io/opentelemetry/instrumentation/jmx/testapp/JavaxSimpleServlet.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package io.opentelemetry.instrumentation.jmx.testapp;
77

88
import java.io.IOException;
9-
import java.io.PrintWriter;
109
import javax.servlet.annotation.WebServlet;
1110
import javax.servlet.http.HttpServlet;
1211
import javax.servlet.http.HttpServletRequest;
@@ -19,8 +18,6 @@ public class JavaxSimpleServlet extends HttpServlet {
1918

2019
@Override
2120
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
22-
try (PrintWriter out = resp.getWriter()) {
23-
out.write("hello!");
24-
}
21+
resp.getWriter().write("hello!");
2522
}
2623
}

0 commit comments

Comments
 (0)