Skip to content

Commit 3803100

Browse files
authored
Review fixes for aws-sdk-2.2:library (open-telemetry#17913)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 4018236 commit 3803100

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

instrumentation/aws-sdk/aws-sdk-2.2/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/Aws2SqsSuppressReceiveSpansTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
import software.amazon.awssdk.services.sqs.SqsAsyncClient;
1414
import software.amazon.awssdk.services.sqs.SqsClient;
1515

16-
public abstract class Aws2SqsSuppressReceiveSpansTest
17-
extends AbstractAws2SqsSuppressReceiveSpansTest {
16+
abstract class Aws2SqsSuppressReceiveSpansTest extends AbstractAws2SqsSuppressReceiveSpansTest {
1817
protected AwsSdkTelemetry telemetry;
1918

2019
@RegisterExtension

instrumentation/aws-sdk/aws-sdk-2.2/library/src/testLambda/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2LambdaTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void noExistingClientContext() {
6363

6464
String newClientContext = newRequest.clientContext();
6565
newClientContext = new String(Base64.getDecoder().decode(newClientContext), UTF_8);
66-
assertThat(newClientContext.contains("traceparent")).isTrue();
66+
assertThat(newClientContext).contains("traceparent");
6767
}
6868

6969
@Test
@@ -78,9 +78,9 @@ void withExistingClientContext() {
7878

7979
String newClientContext = newRequest.clientContext();
8080
newClientContext = new String(Base64.getDecoder().decode(newClientContext), UTF_8);
81-
assertThat(newClientContext.contains("traceparent")).isTrue();
82-
assertThat(newClientContext.contains("preExisting")).isTrue();
83-
assertThat(newClientContext.contains("otherStuff")).isTrue();
81+
assertThat(newClientContext).contains("traceparent");
82+
assertThat(newClientContext).contains("preExisting");
83+
assertThat(newClientContext).contains("otherStuff");
8484
}
8585

8686
@Test
@@ -98,7 +98,7 @@ void exceedingMaximumLengthDoesNotModify() {
9898
}
9999

100100
InvokeRequest request = InvokeRequest.builder().clientContext(long64edClientContext).build();
101-
assertThat(request.clientContext().equals(long64edClientContext)).isTrue();
101+
assertThat(request.clientContext()).isEqualTo(long64edClientContext);
102102

103103
InvokeRequest newRequest =
104104
(InvokeRequest) LambdaImpl.modifyOrAddCustomContextHeader(request, context);

0 commit comments

Comments
 (0)