Skip to content

Commit 38ee182

Browse files
authored
Review fixes for aws-lambda-core-1.0:library (open-telemetry#17271)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 312db96 commit 38ee182

4 files changed

Lines changed: 6 additions & 10 deletions

File tree

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/internal/HeadersFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static Map<String, String> ofStream(InputStream inputStream) {
3232
}
3333
while (parser.nextToken() != JsonToken.END_OBJECT) {
3434
parser.nextToken();
35-
if (!parser.currentName().equals("headers")) {
35+
if (!"headers".equals(parser.currentName())) {
3636
parser.skipChildren();
3737
continue;
3838
}

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/AwsLambdaStreamWrapperHttpPropagationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public void handleRequest(InputStream input, OutputStream output, Context contex
147147
parser.nextToken();
148148
while (parser.nextToken() != JsonToken.END_OBJECT) {
149149
parser.nextToken();
150-
if (!parser.currentName().equals("body")) {
150+
if (!"body".equals(parser.currentName())) {
151151
parser.skipChildren();
152152
continue;
153153
}
@@ -156,7 +156,7 @@ public void handleRequest(InputStream input, OutputStream output, Context contex
156156
}
157157
}
158158
BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(output, UTF_8));
159-
if (body.equals("hello")) {
159+
if ("hello".equals(body)) {
160160
writer.write("world");
161161
writer.flush();
162162
writer.close();

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/AwsLambdaStreamWrapperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ public void handleRequest(InputStream input, OutputStream output, Context contex
124124
BufferedReader reader = new BufferedReader(new InputStreamReader(input, UTF_8));
125125
BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(output, UTF_8));
126126
String line = reader.readLine();
127-
if (line.equals("hello")) {
127+
if ("hello".equals(line)) {
128128
writer.write("world");
129129
writer.flush();
130130
writer.close();

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/LambdaParametersTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ void shouldSetContextOnFirstPosition() throws NoSuchMethodException {
2626
// when
2727
Object[] params = LambdaParameters.toArray(method, "", context);
2828
// then
29-
assertThat(params).hasSize(1);
30-
assertThat(params[0]).isEqualTo(context);
29+
assertThat(params).containsExactly(context);
3130
}
3231

3332
@Test
@@ -39,9 +38,6 @@ void shouldSetContextOnTheLastPosition() throws NoSuchMethodException {
3938
// when
4039
Object[] params = LambdaParameters.toArray(method, "", context);
4140
// then
42-
assertThat(params).hasSize(3);
43-
assertThat(params[0]).isEqualTo("");
44-
assertThat(params[1]).isNull();
45-
assertThat(params[2]).isEqualTo(context);
41+
assertThat(params).containsExactly("", null, context);
4642
}
4743
}

0 commit comments

Comments
 (0)