Skip to content

Commit 3d1be6c

Browse files
authored
Review fixes for opensearch-rest-3.0:javaagent (open-telemetry#17570)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent eaf7350 commit 3d1be6c

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/OpenSearchRestInstrumentationModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public OpenSearchRestInstrumentationModule() {
2424

2525
@Override
2626
public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
27-
// class introduced in 3.0.0
27+
// added in 3.0.0
2828
return hasClassesNamed("org.opensearch.client.http.HttpUriRequestProducer");
2929
}
3030

instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/OpenSearchRestSingletons.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public int getStatusCode() {
3535
}
3636

3737
@Override
38+
@Nullable
3839
public InetAddress getAddress() {
3940
return response.getHost().getAddress();
4041
}

instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/RestClientInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void transform(TypeTransformer transformer) {
4949
getClass().getName() + "$PerformRequestAsyncAdvice");
5050
}
5151

52-
public static class AdviceScope {
52+
public static final class AdviceScope {
5353
private final OpenSearchRestRequest otelRequest;
5454
private final Context parentContext;
5555
private final Context context;

0 commit comments

Comments
 (0)