Rename catch variables to follow naming convention

Rename catch clause variables across the repo:
- `exception` -> `e` for used exception catch variables
- `exception` -> `t` for used Throwable catch variables
- `throwable` -> `t` for used Throwable catch variables
- unused catch parameters -> `ignored`

Author: trask

instrumentation-annotations-support/src/main/java/io/opentelemetry/instrumentation/api/annotation/support/AnnotationReflectionHelper.java

@@ -25,7 +25,7 @@ public static Class<? extends Annotation> forNameOrNull(
       ClassLoader classLoader, String className) {
     try {
       return Class.forName(className, true, classLoader).asSubclass(Annotation.class);
-    } catch (ClassNotFoundException | ClassCastException exception) {
+    } catch (ClassNotFoundException | ClassCastException ignored) {
       return null;
     }
   }

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/internal/SqlCommenterUtil.java

@@ -59,7 +59,7 @@ public static String processQuery(String query, TextMapPropagator propagator, bo
           stringBuilder.append(", ");
         }
       }
-    } catch (UnsupportedEncodingException exception) {
+    } catch (UnsupportedEncodingException e) {
       // this exception should never happen as UTF-8 encoding is always available
     }
     stringBuilder.append("*/");

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/InternalInstrumenterCustomizerUtil.java

@@ -21,7 +21,7 @@ public class InternalInstrumenterCustomizerUtil {
       // this class
       Class.forName(
           "io.opentelemetry.instrumentation.api.incubator.instrumenter.internal.InstrumenterCustomizerUtil");
-    } catch (ClassNotFoundException exception) {
+    } catch (ClassNotFoundException ignored) {
       // incubator api not available, ignore
     }
   }

instrumentation/apache-dubbo-2.7/testing/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTestUtil.java

@@ -20,7 +20,7 @@ static Object newFrameworkModel() {
       return Class.forName("org.apache.dubbo.rpc.model.FrameworkModel")
           .getDeclaredConstructor()
           .newInstance();
-    } catch (ReflectiveOperationException exception) {
+    } catch (ReflectiveOperationException ignored) {
       return null;
     }
   }

instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/AbstractApacheHttpClientTest.java

@@ -41,8 +41,8 @@ public void sendRequestWithCallback(
       HttpClientResult requestResult) {
     try {
       executeRequestWithCallback(request, uri, requestResult);
-    } catch (Throwable throwable) {
-      requestResult.complete(throwable);
+    } catch (Throwable t) {
+      requestResult.complete(t);
     }
   }
 

instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/AbstractApacheHttpClientTest.java

@@ -69,8 +69,8 @@ public void sendRequestWithCallback(
       HttpClientResult httpClientResult) {
     try {
       executeRequestWithCallback(request, uri, httpClientResult);
-    } catch (Throwable throwable) {
-      httpClientResult.complete(throwable);
+    } catch (Throwable t) {
+      httpClientResult.complete(t);
     }
   }
 

instrumentation/armeria/armeria-1.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/v1_3/ServerDecorator.java

@@ -48,12 +48,12 @@ public HttpResponse serve(ServiceRequestContext ctx, HttpRequest req) throws Exc
 
     try {
       return unwrap().serve(ctx, req);
-    } catch (Throwable throwable) {
+    } catch (Throwable t) {
       Span span = Span.fromContext(otelContext);
       span.setStatus(StatusCode.ERROR);
-      span.recordException(ErrorCauseExtractor.getDefault().extract(throwable));
+      span.recordException(ErrorCauseExtractor.getDefault().extract(t));
 
-      throw throwable;
+      throw t;
     }
   }
 }

instrumentation/armeria/armeria-1.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/v1_3/SubscriberWrapper.java

@@ -21,7 +21,7 @@ private static Class<?> getAbortingSubscriberClass() {
     // AbortingSubscriber is package private
     try {
       return Class.forName("com.linecorp.armeria.common.stream.AbortingSubscriber");
-    } catch (ClassNotFoundException exception) {
+    } catch (ClassNotFoundException ignored) {
       return null;
     }
   }
@@ -30,7 +30,7 @@ private static Class<?> getNoopSubscriberClass() {
     // NoopSubscriber is package private
     try {
       return Class.forName("com.linecorp.armeria.common.stream.NoopSubscriber");
-    } catch (ClassNotFoundException exception) {
+    } catch (ClassNotFoundException ignored) {
       return null;
     }
   }

instrumentation/armeria/armeria-1.3/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/internal/RequestContextAccess.java

@@ -38,8 +38,8 @@ private static InetSocketAddress getAddress(
         if (address instanceof InetSocketAddress) {
           return (InetSocketAddress) address;
         }
-      } catch (Throwable throwable) {
-        throw new IllegalStateException("Failed to get address", throwable);
+      } catch (Throwable t) {
+        throw new IllegalStateException("Failed to get address", t);
       }
     }
     return null;

instrumentation/async-http-client/async-http-client-2.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v2_0/AsyncHttpClientTest.java

@@ -51,8 +51,8 @@ private static void setTimeout(
       Method method =
           builder.getClass().getMethod(methodName, testLatestDeps ? Duration.class : int.class);
       method.invoke(builder, testLatestDeps ? Duration.ofMillis(timeout) : timeout);
-    } catch (Exception exception) {
-      throw new IllegalStateException("Failed to set timeout " + methodName, exception);
+    } catch (Exception e) {
+      throw new IllegalStateException("Failed to set timeout " + methodName, e);
     }
   }