Skip to content

Commit 687b65a

Browse files
committed
Update plan and checker after PRs 29-30 merged as open-telemetry#18854
PR 29 (oshi -> oshi-5.0) and PR 30 (elasticsearch-transport-common -> elasticsearch-transport-common-5.0) landed upstream together as open-telemetry#18854. Remove their now-stale unversioned-module allowlist entries from the checker and mark the corresponding plan sections as merged.
1 parent c0e2f45 commit 687b65a

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

.github/scripts/check-package-names.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,11 @@ check_source_set() {
9999
library:jdbc) ;;
100100
library:lettuce-common) ;;
101101
library:netty-common) ;;
102-
library:oshi) ;;
103102
library:resources) ;;
104103
library:runtime-telemetry) ;;
105104
library:servlet-common) ;;
106105
library:servlet-common-javax) ;;
107106
# javaagent:
108-
javaagent:elasticsearch-transport-common) ;;
109107
javaagent:executors) ;;
110108
javaagent:external-annotations) ;;
111109
javaagent:http-url-connection) ;;
@@ -120,7 +118,6 @@ check_source_set() {
120118
javaagent:jsf-common-javax) ;;
121119
javaagent:methods) ;;
122120
javaagent:opentelemetry-instrumentation-api) ;;
123-
javaagent:oshi) ;;
124121
javaagent:rmi) ;;
125122
javaagent:runtime-telemetry) ;;
126123
javaagent:servlet-common) ;;

package-name-exceptions-plan.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Updated on 2026-05-22 after documenting how patch-level base versions map to mod
1616
Updated again on 2026-05-22 after PR 25 merged, Java util logging PR 22 was closed, and app-server/framework PR 27 was split into Payara and Quarkus/Tomcat PRs.
1717
Updated on 2026-05-26 after PRs 27a, 27b, and the Spring testing-package alignment cleanup merged.
1818
Updated again on 2026-05-26 after auditing remaining unversioned-allowlist entries against the documented base-version convention and planning PRs 29-30.
19+
Updated on 2026-05-28 after PRs 29 and 30 merged upstream together as #18854 and their `library:oshi`, `javaagent:oshi`, and `javaagent:elasticsearch-transport-common` allowlist entries were removed from the checker.
1920

2021
## Goal
2122

@@ -91,6 +92,10 @@ PR 25 merged upstream as:
9192

9293
- #18788: `spring-webmvc-common` -> `spring-webmvc-common-3.1`.
9394

95+
PRs 29-30 merged upstream together as:
96+
97+
- #18854: `oshi` -> `oshi-5.0` and `elasticsearch-transport-common` -> `elasticsearch-transport-common-5.0`.
98+
9499
`external-annotations` still remains in the unversioned-module allowlist as `javaagent:external-annotations`; that is a separate module-name exception, not a historical package exception.
95100
`spring-boot-resources` keeps a narrow deprecated compatibility-package exception for `io.opentelemetry.instrumentation.spring.resources`; the replacement javaagent package is already present under `io.opentelemetry.javaagent.instrumentation.spring.boot.resources`.
96101

@@ -368,7 +373,7 @@ Suggested verification:
368373
./gradlew generateFossaConfiguration :instrumentation:quarkus-resteasy-reactive-1.11:javaagent:test :instrumentation:quarkus-resteasy-reactive-1.11:quarkus-2.0-testing:compileTestJava :instrumentation:quarkus-resteasy-reactive-1.11:quarkus-3.0-testing:compileTestJava :instrumentation:quarkus-resteasy-reactive-1.11:quarkus-3.9-testing:compileTestJava :instrumentation:tomcat:tomcat-jdbc-8.5:javaagent:test :instrumentation:tomcat:tomcat-jdbc-8.5:javaagent:testStableSemconv
369374
```
370375

371-
### PR 29: OSHI module name
376+
### PR 29: OSHI module name (merged in #18854)
372377

373378
Modules:
374379

@@ -385,6 +390,7 @@ Notes:
385390
- Javaagent muzzle is `[5.0.0,)` and compiles against `com.github.oshi:oshi-core:5.0.0`; library compiles against `5.3.1` (with a `5.5.0` arm-mac test override). Use `5.0` as the module base version because the javaagent muzzle floor is `5.0.0`.
386391
- Keep `oshi` as the main instrumentation name and add `oshi-5.0` as the versioned alias.
387392
- Update `settings.gradle.kts`, `.fossa.yml`, documentation inventory, and the testing module reference.
393+
- Landed together with PR 30 as #18854.
388394

389395
Suggested verification:
390396

@@ -393,7 +399,7 @@ Suggested verification:
393399
./gradlew generateFossaConfiguration :instrumentation:oshi-5.0:javaagent:test :instrumentation:oshi-5.0:library:test
394400
```
395401

396-
### PR 30: Elasticsearch transport common module name
402+
### PR 30: Elasticsearch transport common module name (merged in #18854)
397403

398404
Modules:
399405

@@ -408,6 +414,7 @@ Notes:
408414
- The common javaagent module has a direct `compileOnly("org.elasticsearch.client:transport:5.0.0")` dependency and is shared by `elasticsearch-transport-5.0`, `elasticsearch-transport-5.3`, and `elasticsearch-transport-6.0`; per #16090 this is the `<lib>-common-<major.minor>` shape.
409415
- Use `5.0` as the base version because that is the minimum supported version across the sibling modules and matches the common module's own `compileOnly` floor.
410416
- Update `settings.gradle.kts`, sibling module Gradle references, and the testing module path.
417+
- Landed together with PR 29 as #18854.
411418

412419
Suggested verification:
413420

@@ -436,9 +443,9 @@ These are probably not the next easiest wins:
436443
- `netty-common`: keep unversioned. No direct Netty compile dependency; explicitly listed as the canonical pure-abstraction example in `.github/agents/knowledge/module-naming.md`. Sibling `netty-common-4.0` carries the version-scoped shared code.
437444
- `lettuce-common`: keep unversioned. No direct Lettuce compile dependency; matches the `netty-common` pure-abstraction shape and is shared by `lettuce-5.0` and `lettuce-5.1`.
438445
- `spring-cloud-gateway-common`: keep unversioned. No direct Spring Cloud Gateway compile dependency; shared by `spring-cloud-gateway-2.0`, `spring-cloud-gateway-2.2`, and the gateway webflux/webmvc sibling modules.
439-
- `elasticsearch-transport-common`: rename to `elasticsearch-transport-common-5.0` (planned above as PR 30). It has a direct `org.elasticsearch.client:transport:5.0.0` compile dependency, matching #16090's `<lib>-common-<major.minor>` shape.
446+
- `elasticsearch-transport-common`: renamed to `elasticsearch-transport-common-5.0` in PR 30 (merged as #18854). It had a direct `org.elasticsearch.client:transport:5.0.0` compile dependency, matching #16090's `<lib>-common-<major.minor>` shape.
440447
- Non-common third-party library modules on the unversioned allowlist need module renames:
441-
- `oshi`: rename to `oshi-5.0` (planned above as PR 29).
448+
- `oshi`: renamed to `oshi-5.0` in PR 29 (merged as #18854).
442449
- `spring-boot-resources`: special case - not a `*-common` module and has no Spring Boot compile dependency (parses `application.yaml`/`bootstrap.yaml` by file convention via `snakeyaml-engine`). Defer until we decide whether a base version is meaningful here; if so, the natural floor is the earliest Spring Boot release whose YAML config layout we still parse.
443450
- App-server/framework module-name cleanups for `payara`, `quarkus-resteasy-reactive`, and `tomcat-jdbc` were completed in PRs 27a-27b.
444451
- Treat this as a checker-policy cleanup first: document legitimate unversioned javaagent module shapes, then only rename leftovers that are true module-name debt.

0 commit comments

Comments
 (0)