Skip to content

Commit 6a32dcf

Browse files
otelbot[bot]trask
andauthored
Review fixes for spring-web-3.1:library (open-telemetry#17744)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
1 parent b78e847 commit 6a32dcf

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

instrumentation/spring/spring-web/spring-web-3.1/library/src/main/java/io/opentelemetry/instrumentation/spring/web/v3_1/HeaderUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ private static MethodHandle firstAvailableHandle(
3838
private static MethodHandle findGetHeadersMethod(MethodType methodType) {
3939
try {
4040
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "get", methodType);
41-
} catch (Throwable t) {
41+
} catch (Throwable ignored) {
4242
return null;
4343
}
4444
}
@@ -51,7 +51,7 @@ static List<String> getHeader(HttpHeaders headers, String name) {
5151
if (result != null) {
5252
return result;
5353
}
54-
} catch (Throwable t) {
54+
} catch (Throwable ignored) {
5555
// ignore
5656
}
5757
}

instrumentation/spring/spring-web/spring-web-3.1/library/src/main/java/io/opentelemetry/instrumentation/spring/web/v3_1/SpringWebHttpAttributesGetter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ public String getHttpRequestMethod(HttpRequest httpRequest) {
6363
}
6464

6565
@Override
66-
@Nullable
6766
public String getUrlFull(HttpRequest httpRequest) {
6867
return httpRequest.getURI().toString();
6968
}

0 commit comments

Comments
 (0)