Skip to content

Commit 71e7474

Browse files
authored
Review fixes for iceberg-1.8:testing (open-telemetry#18011)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 6b40663 commit 71e7474

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

instrumentation/iceberg-1.8/testing/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/AbstractIcebergTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,21 @@
3535
import org.junit.jupiter.api.io.TempDir;
3636

3737
abstract class AbstractIcebergTest {
38-
protected static final int FORMAT_VERSION = 2;
39-
protected static final Schema SCHEMA =
38+
private static final int FORMAT_VERSION = 2;
39+
private static final Schema SCHEMA =
4040
new Schema(
4141
NestedField.required(3, "id", IntegerType.get()),
4242
NestedField.required(4, "data", StringType.get()));
43-
protected static final PartitionSpec SPEC =
43+
private static final PartitionSpec SPEC =
4444
PartitionSpec.builderFor(SCHEMA).bucket("data", 16).build();
45-
protected static final DataFile FILE_1 =
45+
private static final DataFile FILE_1 =
4646
DataFiles.builder(SPEC)
4747
.withPath("/path/to/data-a.parquet")
4848
.withFileSizeInBytes(10L)
4949
.withPartitionPath("data_bucket=0")
5050
.withRecordCount(1L)
5151
.build();
52-
protected static final DataFile FILE_2 =
52+
private static final DataFile FILE_2 =
5353
DataFiles.builder(SPEC)
5454
.withPath("/path/to/data-b.parquet")
5555
.withFileSizeInBytes(10L)
@@ -58,8 +58,8 @@ abstract class AbstractIcebergTest {
5858
.withSplitOffsets(asList(1L))
5959
.build();
6060

61-
@TempDir protected File tableDir = null;
62-
protected Table table;
61+
@TempDir private File tableDir;
62+
private Table table;
6363

6464
protected abstract InstrumentationExtension testing();
6565

@@ -386,7 +386,7 @@ private void assertSizeMetric(
386386
expectedReport.tableName())))));
387387
}
388388

389-
static class SimpleReporter implements MetricsReporter {
389+
private static class SimpleReporter implements MetricsReporter {
390390
private MetricsReport report;
391391

392392
@Override

0 commit comments

Comments
 (0)