Skip to content

Commit 763e2f6

Browse files
committed
Rename metricAssert -> metric in failsafe-3.0 and iceberg-1.8 tests
No behavioral change; pure rename of lambda variable to match repo convention of short names (metric, sum, gauge, point).
1 parent b13eb10 commit 763e2f6

2 files changed

Lines changed: 20 additions & 20 deletions

File tree

instrumentation/failsafe-3.0/library/src/test/java/io/opentelemetry/instrumentation/failsafe/v3_0/FailsafeTelemetryTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ void captureCircuitBreakerMetrics() {
5454
// then
5555
testing.waitAndAssertMetrics(
5656
"io.opentelemetry.failsafe-3.0",
57-
metricAssert ->
58-
metricAssert
57+
metric ->
58+
metric
5959
.hasName("failsafe.circuit_breaker.execution.count")
6060
.hasLongSumSatisfying(
6161
sum ->
@@ -65,8 +65,8 @@ void captureCircuitBreakerMetrics() {
6565
2, "failsafe.circuit_breaker.outcome", "failure"),
6666
buildCircuitBreakerAssertion(
6767
3, "failsafe.circuit_breaker.outcome", "success"))),
68-
metricAssert ->
69-
metricAssert
68+
metric ->
69+
metric
7070
.hasName("failsafe.circuit_breaker.state_change.count")
7171
.hasLongSumSatisfying(
7272
sum ->
@@ -108,17 +108,17 @@ void captureRetryPolicyMetrics() {
108108
// then
109109
testing.waitAndAssertMetrics(
110110
"io.opentelemetry.failsafe-3.0",
111-
metricAssert ->
112-
metricAssert
111+
metric ->
112+
metric
113113
.hasName("failsafe.retry_policy.execution.count")
114114
.hasLongSumSatisfying(
115115
sum ->
116116
sum.isMonotonic()
117117
.hasPointsSatisfying(
118118
buildRetryPolicyAssertion(2, "failure"),
119119
buildRetryPolicyAssertion(3, "success"))),
120-
metricAssert ->
121-
metricAssert
120+
metric ->
121+
metric
122122
.hasName("failsafe.retry_policy.attempts")
123123
.hasHistogramSatisfying(
124124
histogramAssert ->

instrumentation/iceberg-1.8/testing/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/AbstractIcebergTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ private void assertScanDurationMetric(ScanReport expectedReport) {
111111
testing()
112112
.waitAndAssertMetrics(
113113
"io.opentelemetry.iceberg-1.8",
114-
metricAssert ->
115-
metricAssert
114+
metric ->
115+
metric
116116
.hasName("iceberg.scan.planning.duration")
117117
.hasUnit("s")
118118
.hasHistogramSatisfying(
@@ -135,8 +135,8 @@ private void assertDataFilesCountMetrics(ScanReport expectedReport) {
135135
testing()
136136
.waitAndAssertMetrics(
137137
"io.opentelemetry.iceberg-1.8",
138-
metricAssert ->
139-
metricAssert
138+
metric ->
139+
metric
140140
.hasName("iceberg.scan.data_files.count")
141141
.hasUnit("{file}")
142142
.hasLongSumSatisfying(
@@ -172,8 +172,8 @@ private void assertDataManifestCountMetrics(ScanReport expectedReport) {
172172
testing()
173173
.waitAndAssertMetrics(
174174
"io.opentelemetry.iceberg-1.8",
175-
metricAssert ->
176-
metricAssert
175+
metric ->
176+
metric
177177
.hasName("iceberg.scan.data_manifests.count")
178178
.hasUnit("{file}")
179179
.hasLongSumSatisfying(
@@ -215,8 +215,8 @@ private void assertDeleteManifestCountMetrics(ScanReport expectedReport) {
215215
testing()
216216
.waitAndAssertMetrics(
217217
"io.opentelemetry.iceberg-1.8",
218-
metricAssert ->
219-
metricAssert
218+
metric ->
219+
metric
220220
.hasName("iceberg.scan.delete_manifests.count")
221221
.hasUnit("{file}")
222222
.hasLongSumSatisfying(
@@ -258,8 +258,8 @@ private void assertDeleteFilesCountMetrics(ScanReport expectedReport) {
258258
testing()
259259
.waitAndAssertMetrics(
260260
"io.opentelemetry.iceberg-1.8",
261-
metricAssert ->
262-
metricAssert
261+
metric ->
262+
metric
263263
.hasName("iceberg.scan.delete_files.count")
264264
.hasUnit("{file}")
265265
.hasLongSumSatisfying(
@@ -367,8 +367,8 @@ private void assertSizeMetric(
367367
testing()
368368
.waitAndAssertMetrics(
369369
"io.opentelemetry.iceberg-1.8",
370-
metricAssert ->
371-
metricAssert
370+
metric ->
371+
metric
372372
.hasName(otelMetricName)
373373
.hasUnit("By")
374374
.hasLongSumSatisfying(

0 commit comments

Comments
 (0)