Skip to content

Commit 76e005c

Browse files
authored
Review fixes for async-http-client-1.8:javaagent (open-telemetry#17264)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent b36638b commit 76e005c

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

instrumentation/async-http-client/async-http-client-1.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v1_8/AsyncHttpClientInstrumentationModule.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ public AsyncHttpClientInstrumentationModule() {
2525

2626
@Override
2727
public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
28-
// TimeoutsHolder class was added in 1.8.0, not present in 1.7.x
29-
return hasClassesNamed("com.ning.http.client.providers.netty.timeout.TimeoutsHolder");
28+
return hasClassesNamed(
29+
// added in 1.8.0
30+
"com.ning.http.client.providers.netty.timeout.TimeoutsHolder");
3031
}
3132

3233
@Override

instrumentation/async-http-client/async-http-client-1.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v1_8/AsyncHttpClientSingletons.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
public final class AsyncHttpClientSingletons {
1414
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.async-http-client-1.8";
1515

16-
private static final Instrumenter<Request, Response> INSTRUMENTER =
16+
private static final Instrumenter<Request, Response> instrumenter =
1717
AsyncHttpClientInstrumenterFactory.create(
1818
INSTRUMENTATION_NAME, AsyncHttpClient18Helper.INSTANCE);
1919

2020
public static Instrumenter<Request, Response> instrumenter() {
21-
return INSTRUMENTER;
21+
return instrumenter;
2222
}
2323

2424
private AsyncHttpClientSingletons() {}

0 commit comments

Comments
 (0)