Code review sweep (run 24896947952) (open-telemetry#18261)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>

Author: otelbot[bot]

instrumentation/rxjava/rxjava-2.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingObserver.java

@@ -111,7 +111,7 @@ private static Field getQueueDisposableField() {
     return queueDisposableField;
   }
 
-  public static boolean canEnable() {
+  static boolean canEnable() {
     return queueDisposableField != null;
   }
 }

instrumentation/rxjava/rxjava-2.0/library/src/test/java/io/opentelemetry/instrumentation/rxjava/v2_0/RxJava2AsyncOperationEndStrategyTest.java

@@ -45,8 +45,8 @@
 class RxJava2AsyncOperationEndStrategyTest {
   private static final AttributeKey<Boolean> CANCELED_ATTRIBUTE_KEY =
       AttributeKey.booleanKey("rxjava.canceled");
-  @Mock Instrumenter<String, String> instrumenter;
-  @Mock Span span;
+  @Mock private Instrumenter<String, String> instrumenter;
+  @Mock private Span span;
   private final AsyncOperationEndStrategy underTest = RxJava2AsyncOperationEndStrategy.create();
   private final RxJava2AsyncOperationEndStrategy underTestWithExperimentalAttributes =
       RxJava2AsyncOperationEndStrategy.builder().setCaptureExperimentalSpanAttributes(true).build();

instrumentation/rxjava/rxjava-2.0/library/src/test/java/io/opentelemetry/instrumentation/rxjava/v2_0/RxJava2SubscriptionTest.java

@@ -12,9 +12,9 @@
 
 class RxJava2SubscriptionTest extends AbstractRxJava2SubscriptionTest {
   @RegisterExtension
-  static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
 
-  static final TracingAssembly tracingAssembly = TracingAssembly.create();
+  private static final TracingAssembly tracingAssembly = TracingAssembly.create();
 
   @Override
   protected InstrumentationExtension testing() {

instrumentation/rxjava/rxjava-2.0/library/src/test/java/io/opentelemetry/instrumentation/rxjava/v2_0/RxJava2Test.java

@@ -12,9 +12,9 @@
 
 class RxJava2Test extends AbstractRxJava2Test {
   @RegisterExtension
-  static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
 
-  static final TracingAssembly tracingAssembly = TracingAssembly.create();
+  private static final TracingAssembly tracingAssembly = TracingAssembly.create();
 
   @Override
   protected InstrumentationExtension testing() {

instrumentation/rxjava/rxjava-2.0/metadata.yaml

@@ -8,6 +8,7 @@ features:
   - CONTEXT_PROPAGATION
 configurations:
   - name: otel.instrumentation.rxjava.experimental-span-attributes
+    declarative_name: java.rxjava.experimental_span_attributes/development
     description: >
       Enables the experimental span attribute `rxjava.canceled`.
     type: boolean

instrumentation/rxjava/rxjava-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/rxjava/v3_0/RxJava3ExtensionWithSpanTest.java

@@ -14,7 +14,7 @@
 
 class RxJava3ExtensionWithSpanTest extends AbstractRxJava3WithSpanTest {
   @RegisterExtension
-  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
 
   @Override
   protected AbstractTracedWithSpan newTraced() {

instrumentation/rxjava/rxjava-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/rxjava/v3_0/RxJava3InstrumentationWithSpanTest.java

@@ -14,7 +14,7 @@
 
 class RxJava3InstrumentationWithSpanTest extends AbstractRxJava3WithSpanTest {
   @RegisterExtension
-  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
 
   @Override
   protected AbstractTracedWithSpan newTraced() {

instrumentation/rxjava/rxjava-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/rxjava/v3_0/RxJava3SubscriptionTest.java

@@ -12,7 +12,7 @@
 
 class RxJava3SubscriptionTest extends AbstractRxJava3SubscriptionTest {
   @RegisterExtension
-  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
 
   @Override
   protected InstrumentationExtension testing() {

instrumentation/rxjava/rxjava-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/rxjava/v3_0/RxJava3Test.java

@@ -12,7 +12,7 @@
 
 class RxJava3Test extends AbstractRxJava3Test {
   @RegisterExtension
-  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+  private static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
 
   @Override
   protected InstrumentationExtension testing() {