Limit ExceptionLogger to ByteBuddy suppression

Author: trask

.github/agents/knowledge/general-rules.md

@@ -60,15 +60,12 @@ Only flag substantive problems, not stylistic preference.
 ## [Javaagent] Best-Effort Suppressed Failures
 
 When javaagent runtime code intentionally suppresses a `Throwable` to avoid breaking the
-application, do not silently swallow it.
-
-- Prefer `ExceptionLogger.logSuppressedError(...)` for suppressed failures in javaagent code.
-  It logs at `FINE` and matches the agent's default ByteBuddy advice suppression path in
-  `ExceptionHandlers.defaultExceptionHandler()`.
-- Use this for best-effort hooks such as response customizers, bootstrap fallbacks, or other
-  optional extension points where failure must not change application behavior.
-- Do not introduce ad-hoc local loggers for one-off suppressed javaagent failures when
-  `ExceptionLogger` is available from bootstrap.
+application, do not silently swallow it unless the failure is an expected optional probe.
+
+- In ordinary instrumentation implementation code, local JUL `logger.log(FINE, ...)` is an
+  established pattern and preserves module / class logger identity.
+- Silent suppression is acceptable for expected optional-probe paths, such as classpath or
+  version-detection lookups where failure is routine and logging would be noisy.
 - Keep the message action-oriented and specific (for example, "Failed to customize Netty 4.1
   HTTP server response").
 

instrumentation/redisson/redisson-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/RedissonRequest.java

@@ -7,13 +7,13 @@
 
 import static java.util.Collections.emptyList;
 import static java.util.Collections.singletonList;
+import static java.util.logging.Level.FINE;
 
 import com.google.auto.value.AutoValue;
 import io.netty.buffer.ByteBuf;
 import io.opentelemetry.api.GlobalOpenTelemetry;
 import io.opentelemetry.instrumentation.api.incubator.config.internal.DbConfig;
 import io.opentelemetry.instrumentation.api.incubator.semconv.db.RedisCommandSanitizer;
-import io.opentelemetry.javaagent.bootstrap.ExceptionLogger;
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
 import java.lang.invoke.MethodType;
@@ -22,13 +22,16 @@
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
+import java.util.logging.Logger;
 import javax.annotation.Nullable;
 import org.redisson.client.protocol.CommandData;
 import org.redisson.client.protocol.CommandsData;
 
 @AutoValue
 public abstract class RedissonRequest {
 
+  private static final Logger logger = Logger.getLogger(RedissonRequest.class.getName());
+
   private static final RedisCommandSanitizer sanitizer =
       RedisCommandSanitizer.create(
           DbConfig.isQuerySanitizationEnabled(GlobalOpenTelemetry.get(), "redisson"));
@@ -126,14 +129,14 @@ private CompletionStage<?> getPromise() {
       try {
         return (CompletionStage<?>) COMMAND_DATA_GET_PROMISE.invoke(command);
       } catch (Throwable t) {
-        ExceptionLogger.logSuppressedError("Failed to get Redisson command promise", t);
+        logger.log(FINE, "Failed to get Redisson command promise", t);
         return null;
       }
     } else if (command instanceof CommandsData && COMMANDS_DATA_GET_PROMISE != null) {
       try {
         return (CompletionStage<?>) COMMANDS_DATA_GET_PROMISE.invoke(command);
       } catch (Throwable t) {
-        ExceptionLogger.logSuppressedError("Failed to get Redisson commands promise", t);
+        logger.log(FINE, "Failed to get Redisson commands promise", t);
         return null;
       }
     }

javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/IndyBootstrapDispatcher.java

@@ -5,13 +5,16 @@
 
 package io.opentelemetry.javaagent.bootstrap;
 
+import static java.util.logging.Level.FINE;
+
 import io.opentelemetry.instrumentation.api.internal.Initializer;
 import java.lang.invoke.CallSite;
 import java.lang.invoke.ConstantCallSite;
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
 import java.lang.invoke.MethodType;
 import java.lang.reflect.Array;
+import java.util.logging.Logger;
 import javax.annotation.Nullable;
 
 /**
@@ -20,6 +23,8 @@
  */
 public class IndyBootstrapDispatcher {
 
+  private static final Logger logger = Logger.getLogger(IndyBootstrapDispatcher.class.getName());
+
   private static volatile MethodHandle bootstrap;
 
   private IndyBootstrapDispatcher() {}
@@ -45,7 +50,7 @@ public static CallSite bootstrap(
       try {
         callSite = (CallSite) bootstrap.invoke(lookup, adviceMethodName, adviceMethodType, args);
       } catch (Throwable e) {
-        ExceptionLogger.logSuppressedError("Error bootstrapping indy instruction", e);
+        logger.log(FINE, "Error bootstrapping indy instruction", e);
       }
     }
     if (callSite == null) {

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java

@@ -22,7 +22,6 @@
 import io.opentelemetry.javaagent.bootstrap.AgentClassLoader;
 import io.opentelemetry.javaagent.bootstrap.BootstrapPackagePrefixesHolder;
 import io.opentelemetry.javaagent.bootstrap.DefineClassHelper;
-import io.opentelemetry.javaagent.bootstrap.ExceptionLogger;
 import io.opentelemetry.javaagent.bootstrap.InstrumentedTaskClasses;
 import io.opentelemetry.javaagent.bootstrap.LambdaTransformer;
 import io.opentelemetry.javaagent.bootstrap.LambdaTransformerHolder;
@@ -317,7 +316,8 @@ public <T> void customize(
               try {
                 modifier.customize(serverContext, response, responseMutator);
               } catch (Throwable t) {
-                ExceptionLogger.logSuppressedError(
+                logger.log(
+                    FINE,
                     "Failed to customize HTTP server response with "
                         + modifier.getClass().getName(),
                     t);