Skip to content

Commit 9597b01

Browse files
committed
enum singletons
1 parent 8354807 commit 9597b01

4 files changed

Lines changed: 8 additions & 21 deletions

File tree

instrumentation/grizzly-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/grizzly/v2_3/GrizzlyHttpResponseMutator.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,8 @@
1010
import org.glassfish.grizzly.http.util.DataChunk;
1111
import org.glassfish.grizzly.http.util.MimeHeaders;
1212

13-
public class GrizzlyHttpResponseMutator implements HttpServerResponseMutator<HttpResponsePacket> {
14-
15-
public static final GrizzlyHttpResponseMutator INSTANCE = new GrizzlyHttpResponseMutator();
16-
17-
private GrizzlyHttpResponseMutator() {}
13+
public enum GrizzlyHttpResponseMutator implements HttpServerResponseMutator<HttpResponsePacket> {
14+
INSTANCE;
1815

1916
@Override
2017
public void appendHeader(HttpResponsePacket response, String name, String value) {

instrumentation/jetty/jetty-12.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/v12_0/Jetty12ResponseMutator.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,8 @@
88
import io.opentelemetry.javaagent.bootstrap.http.HttpServerResponseMutator;
99
import org.eclipse.jetty.server.Response;
1010

11-
class Jetty12ResponseMutator implements HttpServerResponseMutator<Response> {
12-
13-
public static final Jetty12ResponseMutator INSTANCE = new Jetty12ResponseMutator();
14-
15-
private Jetty12ResponseMutator() {}
11+
enum Jetty12ResponseMutator implements HttpServerResponseMutator<Response> {
12+
INSTANCE;
1613

1714
@Override
1815
public void appendHeader(Response response, String name, String value) {

instrumentation/jetty/jetty-8.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/Jetty8ResponseMutator.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,8 @@
88
import io.opentelemetry.javaagent.bootstrap.http.HttpServerResponseMutator;
99
import javax.servlet.http.HttpServletResponse;
1010

11-
final class Jetty8ResponseMutator implements HttpServerResponseMutator<HttpServletResponse> {
12-
13-
static final Jetty8ResponseMutator INSTANCE = new Jetty8ResponseMutator();
14-
15-
private Jetty8ResponseMutator() {}
11+
enum Jetty8ResponseMutator implements HttpServerResponseMutator<HttpServletResponse> {
12+
INSTANCE;
1613

1714
@Override
1815
public void appendHeader(HttpServletResponse response, String name, String value) {

instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3HttpServerResponseMutator.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,9 @@
88
import io.opentelemetry.javaagent.bootstrap.http.HttpServerResponseMutator;
99
import javax.servlet.http.HttpServletResponse;
1010

11-
public class Servlet3HttpServerResponseMutator
11+
public enum Servlet3HttpServerResponseMutator
1212
implements HttpServerResponseMutator<HttpServletResponse> {
13-
14-
public static final Servlet3HttpServerResponseMutator INSTANCE =
15-
new Servlet3HttpServerResponseMutator();
16-
17-
private Servlet3HttpServerResponseMutator() {}
13+
INSTANCE;
1814

1915
@Override
2016
public void appendHeader(HttpServletResponse response, String name, String value) {

0 commit comments

Comments
 (0)