Skip to content

Commit a579949

Browse files
committed
Reduce flakiness in io.opentelemetry.javaagent.instrumentation.playmvc.v2_4.server.PlayServerTest.successfulGetRequest(int)[3]
Automated fix attempt based on Develocity flaky-test analysis.
1 parent b9b76a4 commit a579949

1 file changed

Lines changed: 15 additions & 1 deletion

File tree

  • instrumentation/play/play-mvc/play-mvc-2.4/javaagent/src/play24Test/java/io/opentelemetry/javaagent/instrumentation/playmvc/v2_4/server

instrumentation/play/play-mvc/play-mvc-2.4/javaagent/src/play24Test/java/io/opentelemetry/javaagent/instrumentation/playmvc/v2_4/server/PlayServerTest.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ protected Server setupServer() {
4747
.routeTo(
4848
() ->
4949
controller(
50-
SUCCESS, () -> Results.status(SUCCESS.getStatus(), SUCCESS.getBody())))
50+
SUCCESS,
51+
() ->
52+
closeConnection(
53+
Results.status(SUCCESS.getStatus(), SUCCESS.getBody()))))
5154
.GET(INDEXED_CHILD.getPath())
5255
.routeTo(
5356
() ->
@@ -103,6 +106,17 @@ protected Server setupServer() {
103106
return Server.forRouter(router.build(), port);
104107
}
105108

109+
private static Results.Status closeConnection(Results.Status javaResult) {
110+
Tuple2<String, String> header = new Tuple2<>("Connection", "close");
111+
return new Results.Status(
112+
javaResult
113+
.toScala()
114+
.withHeaders(
115+
JavaConverters.asScalaIteratorConverter(singletonList(header).iterator())
116+
.asScala()
117+
.toSeq()));
118+
}
119+
106120
@Override
107121
protected void stopServer(Server server) {
108122
server.stop();

0 commit comments

Comments
 (0)