Skip to content

Commit ac103ca

Browse files
committed
Review fixes for r2dbc-1.0:javaagent
Automated code review of instrumentation/r2dbc-1.0/javaagent.
1 parent ec3d575 commit ac103ca

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

instrumentation/r2dbc-1.0/javaagent/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ muzzle {
77
pass {
88
group.set("io.r2dbc")
99
module.set("r2dbc-spi")
10-
versions.set("[1.0.0.RELEASE,)")
10+
versions.set("[0.9.0.RELEASE,)")
11+
assertInverse.set(true)
1112
extraDependency("io.projectreactor:reactor-core:3.4.12")
1213
}
1314
}

instrumentation/r2dbc-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/r2dbc/v1_0/R2dbcInstrumentation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.javaagent.instrumentation.r2dbc.v1_0;
77

8+
import static io.opentelemetry.javaagent.instrumentation.r2dbc.v1_0.R2dbcSingletons.telemetry;
89
import static net.bytebuddy.matcher.ElementMatchers.named;
910
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
1011
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
@@ -48,7 +49,7 @@ public static ConnectionFactory methodExit(
4849
return null;
4950
}
5051

51-
return R2dbcSingletons.telemetry().wrapConnectionFactory(factory, factoryOptions);
52+
return telemetry().wrapConnectionFactory(factory, factoryOptions);
5253
}
5354
}
5455
}

instrumentation/r2dbc-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/r2dbc/v1_0/R2dbcSingletons.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
public class R2dbcSingletons {
1818

19-
private static final R2dbcTelemetry TELEMETRY;
19+
private static final R2dbcTelemetry telemetry;
2020

2121
static {
2222
R2dbcTelemetryBuilder builder =
@@ -32,11 +32,11 @@ public class R2dbcSingletons {
3232
builder,
3333
sqlCommenterBuilder ->
3434
SqlCommenterCustomizerHolder.getCustomizer().customize(sqlCommenterBuilder));
35-
TELEMETRY = builder.build();
35+
telemetry = builder.build();
3636
}
3737

3838
public static R2dbcTelemetry telemetry() {
39-
return TELEMETRY;
39+
return telemetry;
4040
}
4141

4242
private R2dbcSingletons() {}

0 commit comments

Comments
 (0)