Skip to content

Commit b355146

Browse files
committed
review
1 parent 767baa8 commit b355146

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version35Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
3636
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_USER;
3737
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DbSystemNameIncubatingValues.HSQLDB;
38+
import static java.util.concurrent.TimeUnit.NANOSECONDS;
3839
import static java.util.concurrent.TimeUnit.SECONDS;
3940
import static org.assertj.core.api.Assertions.assertThat;
4041

@@ -188,8 +189,9 @@ void highConcurrency() throws Exception {
188189
}
189190

190191
latch.countDown();
192+
long deadlineNanos = System.nanoTime() + SECONDS.toNanos(30);
191193
for (Future<?> future : futures) {
192-
future.get(30, SECONDS);
194+
future.get(Math.max(deadlineNanos - System.nanoTime(), 0), NANOSECONDS);
193195
}
194196

195197
List<Consumer<TraceAssert>> assertions = new ArrayList<>();

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version41Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
3636
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_USER;
3737
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DbSystemNameIncubatingValues.HSQLDB;
38+
import static java.util.concurrent.TimeUnit.NANOSECONDS;
3839
import static java.util.concurrent.TimeUnit.SECONDS;
3940
import static org.assertj.core.api.Assertions.assertThat;
4041

@@ -188,8 +189,9 @@ void highConcurrency() throws Exception {
188189
}
189190

190191
latch.countDown();
192+
long deadlineNanos = System.nanoTime() + SECONDS.toNanos(30);
191193
for (Future<?> future : futures) {
192-
future.get(30, SECONDS);
194+
future.get(Math.max(deadlineNanos - System.nanoTime(), 0), NANOSECONDS);
193195
}
194196

195197
List<Consumer<TraceAssert>> assertions = new ArrayList<>();

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version5Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
3636
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_USER;
3737
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DbSystemNameIncubatingValues.HSQLDB;
38+
import static java.util.concurrent.TimeUnit.NANOSECONDS;
3839
import static java.util.concurrent.TimeUnit.SECONDS;
3940
import static org.assertj.core.api.Assertions.assertThat;
4041

@@ -188,8 +189,9 @@ void highConcurrency() throws Exception {
188189
}
189190

190191
latch.countDown();
192+
long deadlineNanos = System.nanoTime() + SECONDS.toNanos(30);
191193
for (Future<?> future : futures) {
192-
future.get(30, SECONDS);
194+
future.get(Math.max(deadlineNanos - System.nanoTime(), 0), NANOSECONDS);
193195
}
194196

195197
List<Consumer<TraceAssert>> assertions = new ArrayList<>();

0 commit comments

Comments
 (0)