Skip to content

Commit b6d6fce

Browse files
authored
Review fixes for jsf-myfaces-1.2:javaagent (open-telemetry#17481)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 13dff82 commit b6d6fce

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/MyFacesErrorCauseExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import io.opentelemetry.javaagent.instrumentation.jsf.javax.JsfErrorCauseExtractor;
99
import javax.el.ELException;
1010

11-
public class MyFacesErrorCauseExtractor extends JsfErrorCauseExtractor {
11+
final class MyFacesErrorCauseExtractor extends JsfErrorCauseExtractor {
1212

1313
@Override
1414
public Throwable extract(Throwable error) {

instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/MyFacesInstrumentationModule.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ public MyFacesInstrumentationModule() {
2424

2525
@Override
2626
public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
27-
// javax.faces was renamed to jakarta.faces in JSF 3.0
28-
return hasClassesNamed("javax.faces.context.FacesContext");
27+
return hasClassesNamed(
28+
// removed in 3.0
29+
"javax.faces.context.FacesContext");
2930
}
3031

3132
@Override

instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/MyFacesSingletons.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
1111
import io.opentelemetry.javaagent.instrumentation.jsf.javax.JsfRequest;
1212

13-
public class MyFacesSingletons {
13+
final class MyFacesSingletons {
1414
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.jsf-myfaces-1.2";
1515

1616
private static final Instrumenter<JsfRequest, Void> instrumenter;

0 commit comments

Comments
 (0)