Skip to content

Commit cf1c834

Browse files
committed
Improve Tomcat 10 classloader matcher
1 parent e84cdb9 commit cf1c834

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

instrumentation/tomcat/tomcat-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/tomcat/v10_0/Tomcat10InstrumentationModule.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed;
99
import static io.opentelemetry.javaagent.instrumentation.tomcat.v10_0.Tomcat10Singletons.helper;
1010
import static java.util.Collections.singletonList;
11+
import static net.bytebuddy.matcher.ElementMatchers.not;
1112

1213
import com.google.auto.service.AutoService;
1314
import io.opentelemetry.context.Context;
@@ -33,13 +34,13 @@ public Tomcat10InstrumentationModule() {
3334

3435
@Override
3536
public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
36-
// added in Servlet 5.0 (renamed from javax.servlet)
37-
return hasClassesNamed("jakarta.servlet.http.HttpServletRequest")
38-
.and(
39-
// added in 10.0.11
40-
hasClassesNamed("org.apache.catalina.users.GenericUser")
41-
// removed in 10.0.26
42-
.or(hasClassesNamed("org.apache.catalina.webresources.Cache$EvictionOrder")));
37+
return hasClassesNamed(
38+
// added in Servlet 5.0 (renamed from javax.servlet)
39+
"jakarta.servlet.http.HttpServletRequest",
40+
// Tomcat request class
41+
"org.apache.coyote.Request")
42+
// removed in 10.0
43+
.and(not(hasClassesNamed("org.apache.catalina.loader.Constants")));
4344
}
4445

4546
@Override

0 commit comments

Comments
 (0)