Skip to content

Commit d6204d9

Browse files
committed
Make some fields final
1 parent aad0b0f commit d6204d9

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

  • instrumentation/xxl-job/xxl-job-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/xxljob/common

instrumentation/xxl-job/xxl-job-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/xxljob/common/XxlJobProcessRequest.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,34 +12,23 @@
1212

1313
public final class XxlJobProcessRequest {
1414

15-
@Nullable private String methodName;
16-
private int jobId;
17-
@Nullable private Class<?> declaringClass;
15+
@Nullable private final String methodName;
16+
private final int jobId;
17+
@Nullable private final Class<?> declaringClass;
1818
private boolean failed;
1919
private final GlueTypeEnum glueType;
2020

21-
private XxlJobProcessRequest(GlueTypeEnum glueType) {
22-
this.glueType = glueType;
23-
}
24-
2521
public static XxlJobProcessRequest createRequestForMethod(
2622
GlueTypeEnum glueType, Class<?> declaringClass, @Nullable String methodName) {
27-
XxlJobProcessRequest request = new XxlJobProcessRequest(glueType);
28-
request.declaringClass = declaringClass;
29-
request.methodName = methodName;
30-
31-
return request;
23+
return new XxlJobProcessRequest(glueType, declaringClass, methodName, 0);
3224
}
3325

3426
public static XxlJobProcessRequest createGlueJobRequest(IJobHandler handler) {
3527
return createRequestForMethod(GlueTypeEnum.GLUE_GROOVY, handler.getClass(), "execute");
3628
}
3729

3830
public static XxlJobProcessRequest createScriptJobRequest(GlueTypeEnum glueType, int jobId) {
39-
XxlJobProcessRequest request = new XxlJobProcessRequest(glueType);
40-
request.jobId = jobId;
41-
42-
return request;
31+
return new XxlJobProcessRequest(glueType, null, null, jobId);
4332
}
4433

4534
public static XxlJobProcessRequest createSimpleJobRequest(IJobHandler handler) {
@@ -52,6 +41,17 @@ public static XxlJobProcessRequest createMethodJobRequest(
5241
GlueTypeEnum.BEAN, target.getClass(), method != null ? method.getName() : null);
5342
}
5443

44+
private XxlJobProcessRequest(
45+
GlueTypeEnum glueType,
46+
@Nullable Class<?> declaringClass,
47+
@Nullable String methodName,
48+
int jobId) {
49+
this.glueType = glueType;
50+
this.declaringClass = declaringClass;
51+
this.methodName = methodName;
52+
this.jobId = jobId;
53+
}
54+
5555
public void setFailed() {
5656
failed = true;
5757
}

0 commit comments

Comments
 (0)