review

Author: trask

instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/parser/MssqlUrlParser.java

@@ -126,14 +126,10 @@ private static String parseUrlWithInstance(String jdbcUrl, ParseContext ctx) {
     int instanceLoc = serverName.indexOf("\\");
     if (instanceLoc > 0) {
       if (hostPort.ipv6Address() != null) {
-        // For IPv6 with instance: [2001:db8::1]\INSTANCE
-        // Extract instance name between backslash and closing bracket
         int closingBracket = serverName.lastIndexOf(']');
-        if (closingBracket > instanceLoc) {
-          instanceName = serverName.substring(instanceLoc + 1, closingBracket);
-          // Reconstruct host with just the IPv6 address
-          serverName = "[" + hostPort.ipv6Address() + "]";
-        }
+        int instanceEnd = closingBracket > instanceLoc ? closingBracket : serverName.length();
+        instanceName = serverName.substring(instanceLoc + 1, instanceEnd);
+        serverName = "[" + hostPort.ipv6Address() + "]";
       } else {
         instanceName = serverName.substring(instanceLoc + 1);
         serverName = serverName.substring(0, instanceLoc);

instrumentation/jdbc/library/src/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java

@@ -465,6 +465,15 @@ private static Stream<Arguments> sqlServerArguments() {
             .setPort(43)
             .setName("ssinstance")
             .build(),
+        arg("jdbc:sqlserver://[3ffe:8311:eeee:f70f:0:5eae:10.203.31.9]\\ssinstance;databaseName=ssdb")
+            .setShortUrl("sqlserver://[3ffe:8311:eeee:f70f:0:5eae:10.203.31.9]:1433")
+            .setSystem("microsoft.sql_server")
+            .setOldSystem("mssql")
+            .setHost("[3ffe:8311:eeee:f70f:0:5eae:10.203.31.9]")
+            .setPort(1433)
+            .setNamespace("ssinstance|ssdb")
+            .setName("ssinstance")
+            .build(),
         arg("jdbc:microsoft:sqlserver://;")
             .setProperties(stdProps())
             .setShortUrl("microsoft:sqlserver://stdServerName:9999")