Add JMX and JFR test coverage to unified runtime-telemetry javaagent module

Author: trask

instrumentation/runtime-telemetry/javaagent/build.gradle.kts

@@ -15,5 +15,22 @@ dependencies {
 tasks {
   test {
     jvmArgs("-Dotel.instrumentation.runtime-telemetry.experimental.package-emitter.enabled=true")
+    filter {
+      excludeTestsMatching("*.JfrRuntimeMetricsTest")
+      isFailOnNoMatchingTests = false
+    }
+  }
+
+  val testJfr by registering(Test::class) {
+    testClassesDirs = sourceSets.test.get().output.classesDirs
+    classpath = sourceSets.test.get().runtimeClasspath
+    jvmArgs("-Dotel.instrumentation.runtime-telemetry.emit-experimental-jfr-metrics=true")
+    filter {
+      includeTestsMatching("*.JfrRuntimeMetricsTest")
+    }
+  }
+
+  check {
+    dependsOn(testJfr)
   }
 }

instrumentation/runtime-telemetry/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/runtimetelemetry/JfrRuntimeMetricsTest.java

@@ -0,0 +1,48 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.runtimetelemetry;
+
+import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
+import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
+import org.junit.jupiter.api.Assumptions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+class JfrRuntimeMetricsTest {
+
+  @RegisterExtension
+  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+
+  @BeforeAll
+  static void setUp() {
+    // Use reflection to avoid a compile-time dependency on jdk.jfr (Java 11+), since this test
+    // module targets the agent's minimum supported Java version.
+    Class<?> flightRecorderClass;
+    try {
+      flightRecorderClass = Class.forName("jdk.jfr.FlightRecorder");
+    } catch (ClassNotFoundException e) {
+      Assumptions.abort("JFR not present");
+      return;
+    }
+    boolean available;
+    try {
+      available = (boolean) flightRecorderClass.getMethod("isAvailable").invoke(null);
+    } catch (ReflectiveOperationException e) {
+      throw new IllegalStateException(e);
+    }
+    Assumptions.assumeTrue(available, "JFR not available");
+  }
+
+  @Test
+  void shouldHaveJfrMetrics() {
+    // This should generate some events
+    System.gc();
+
+    testing.waitAndAssertMetrics(
+        "io.opentelemetry.runtime-telemetry", metric -> metric.hasName("jvm.cpu.context_switch"));
+  }
+}

instrumentation/runtime-telemetry/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/runtimetelemetry/JmxRuntimeMetricsTest.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.runtimetelemetry;
+
+import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
+import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+class JmxRuntimeMetricsTest {
+
+  @RegisterExtension
+  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+
+  @Test
+  void runtimeMetricsAreEnabled() {
+    // Force a gc to "ensure" gc metrics
+    System.gc();
+
+    testing.waitAndAssertMetrics(
+        "io.opentelemetry.runtime-telemetry-java8",
+        metric -> metric.hasName("jvm.class.loaded"),
+        metric -> metric.hasName("jvm.class.unloaded"),
+        metric -> metric.hasName("jvm.class.count"),
+        metric -> metric.hasName("jvm.cpu.time"),
+        metric -> metric.hasName("jvm.cpu.count"),
+        metric -> metric.hasName("jvm.cpu.recent_utilization"),
+        metric -> metric.hasName("jvm.gc.duration"),
+        metric -> metric.hasName("jvm.memory.used"),
+        metric -> metric.hasName("jvm.memory.committed"),
+        metric -> metric.hasName("jvm.memory.limit"),
+        metric -> metric.hasName("jvm.memory.used_after_last_gc"),
+        metric -> metric.hasName("jvm.thread.count"));
+  }
+}