Skip to content

Commit e6d8ce6

Browse files
committed
run-local.py: always open PR as draft
Local-mode runs are exploratory; force --draft so it never accidentally pings reviewers before the developer has eyeballed the diff. Drops the --draft CLI flag (no longer optional).
1 parent 0488ebe commit e6d8ce6

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

.github/scripts/flaky-test-fix/run-local.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ def stash_toolkit(start_branch, dest):
4848

4949

5050
def main():
51-
draft = "--draft" in sys.argv[1:]
52-
5351
repo_root = Path(git("rev-parse", "--show-toplevel"))
5452
os.chdir(repo_root)
5553
OUT_DIR.mkdir(parents=True, exist_ok=True)
@@ -118,7 +116,7 @@ def main():
118116
git("push", "-u", FORK_REMOTE, branch)
119117

120118
print(f"==> Rendering PR body + opening PR against "
121-
f"{UPSTREAM_REMOTE}/{BASE_BRANCH}{' (draft)' if draft else ''}")
119+
f"{UPSTREAM_REMOTE}/{BASE_BRANCH} (draft)")
122120
fork_url = git("remote", "get-url", FORK_REMOTE)
123121
upstream_url = git("remote", "get-url", UPSTREAM_REMOTE)
124122
head_owner = re.match(r"^.*github\.com[:/]([^/]+)/", fork_url).group(1)
@@ -127,8 +125,7 @@ def main():
127125
os.environ["PR_HEAD"] = f"{head_owner}:{branch}"
128126
os.environ["PR_BASE"] = BASE_BRANCH
129127
os.environ["PR_REPO"] = upstream_repo
130-
if draft:
131-
os.environ["PR_DRAFT"] = "1"
128+
os.environ["PR_DRAFT"] = "1" # local runs always open as draft
132129
subprocess.run(
133130
["python", str(Path(toolkit) / "3-open-pr.py")], check=True)
134131

0 commit comments

Comments
 (0)