Make static helper fields private

Author: trask

instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/RequestAccess.java

@@ -189,7 +189,7 @@ private static MethodHandle findLambdaGetConfigurationMethod(Class<?> clz) {
   }
 
   private static class LambdaFunctionConfigurationAccess {
-    static final MethodHandle getLambdaArnFromConfiguration = findGetLambdaArnMethod();
+    private static final MethodHandle getLambdaArnFromConfiguration = findGetLambdaArnMethod();
 
     @Nullable
     private static MethodHandle findGetLambdaArnMethod() {

instrumentation/log4j/log4j-context-data/log4j-context-data-2.17/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/log4j/contextdata/v2_17/OpenTelemetryContextDataProvider.java

@@ -95,15 +95,15 @@ public Map<String, String> supplyContextData() {
 
   private static class Configuration {
     @SuppressWarnings("deprecation") // using deprecated config property
-    static final boolean baggageEnabled =
+    private static final boolean baggageEnabled =
         DeclarativeConfigUtil.getInstrumentationConfig(
                 GlobalOpenTelemetry.getOrNoop(), "log4j_context_data")
             .getBoolean(
                 "add_baggage",
                 ConfigPropertiesUtil.getBoolean(
                     "otel.instrumentation.log4j-context-data.add-baggage", false));
 
-    static final ContextDataKeys contextDataKeys =
+    private static final ContextDataKeys contextDataKeys =
         ContextDataKeys.create(GlobalOpenTelemetry.getOrNoop());
   }
 }

instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java

@@ -713,7 +713,7 @@ private interface FieldReader {
 
   private static class LogstashFieldReaderHolder {
     // keeping this field in a separate class because ClassValue is missing in some android versions
-    static final ClassValue<FieldReader> valueField =
+    private static final ClassValue<FieldReader> valueField =
         new ClassValue<FieldReader>() {
           @Override
           protected FieldReader computeValue(Class<?> type) {

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/matcher/ClassLoaderHasClassesNamedMatcher.java

@@ -17,7 +17,7 @@
 class ClassLoaderHasClassesNamedMatcher extends ElementMatcher.Junction.AbstractBase<ClassLoader> {
   // caching is disabled for build time muzzle checks
   // this field is set via reflection from ClassLoaderMatcher
-  static boolean useCache = true;
+  private static boolean useCache = true;
   private static final AtomicInteger counter = new AtomicInteger();
 
   private final String[] resources;

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/InstrumentationModuleInstaller.java

@@ -48,7 +48,7 @@
 
 public final class InstrumentationModuleInstaller {
 
-  static final TransformSafeLogger logger =
+  private static final TransformSafeLogger logger =
       TransformSafeLogger.getLogger(InstrumentationModule.class);
 
   // Added here instead of AgentInstaller's ignores because it's relatively