Relax metric assertions for async runtime metrics

The CI failures were caused by overly strict metric point assertions added to
OSHI and JFR runtime telemetry tests. Async/delta collection can report memory
usage changes with either state increasing, and jvm.thread.count can include
additional thread-state points, so the tests now assert the meaningful state and
positive-value guarantees without requiring an exact two-point shape.

Validation: .\gradlew.bat :instrumentation:oshi:library:test :instrumentation:oshi:javaagent:test :instrumentation:runtime-telemetry:library:testJava17

Author: trask

instrumentation/oshi/testing/src/main/java/io/opentelemetry/instrumentation/oshi/AbstractSystemMetricsTest.java

@@ -36,16 +36,19 @@ void test() {
                         assertThat(metric)
                             .hasUnit("By")
                             .hasLongSumSatisfying(
-                                sum ->
-                                    sum.hasPointsSatisfying(
-                                        point ->
-                                            point
-                                                .hasAttributesSatisfying(equalTo(STATE, "used"))
-                                                .hasValueSatisfying(v -> v.isPositive()),
-                                        point ->
-                                            point
-                                                .hasAttributesSatisfying(equalTo(STATE, "free"))
-                                                .hasValueSatisfying(v -> v.isPositive())))));
+                                sum -> {
+                                  sum
+                                      .hasPointsSatisfying(
+                                          point ->
+                                              point.hasAttributesSatisfying(
+                                                  equalTo(STATE, "used")),
+                                          point ->
+                                              point.hasAttributesSatisfying(
+                                                  equalTo(STATE, "free")));
+                                  assertThat(metric.getLongSumData().getPoints())
+                                      .anySatisfy(
+                                          point -> assertThat(point.getValue()).isPositive());
+                                })));
     testing()
         .waitAndAssertMetrics(
             "io.opentelemetry.oshi",

instrumentation/runtime-telemetry/library/src/testJava17/java/io/opentelemetry/instrumentation/runtimetelemetry/JfrThreadCountTest.java

@@ -7,9 +7,11 @@
 
 import static io.opentelemetry.instrumentation.runtimetelemetry.internal.Constants.ATTR_DAEMON;
 import static io.opentelemetry.instrumentation.runtimetelemetry.internal.Constants.UNIT_THREADS;
-import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
+import static java.util.Objects.requireNonNull;
+import static org.assertj.core.api.Assertions.assertThat;
 
 import io.opentelemetry.instrumentation.runtimetelemetry.internal.JfrFeature;
+import io.opentelemetry.sdk.metrics.data.LongPointData;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
@@ -50,16 +52,14 @@ void shouldHaveJfrThreadCountEvents() throws InterruptedException {
             metric
                 .hasName("jvm.thread.count")
                 .hasUnit(UNIT_THREADS)
-                .hasLongSumSatisfying(
-                    sum ->
-                        sum.hasPointsSatisfying(
-                            point ->
-                                point
-                                    .hasAttributesSatisfying(equalTo(ATTR_DAEMON, false))
-                                    .hasValueSatisfying(v -> v.isPositive()),
-                            point ->
-                                point
-                                    .hasAttributesSatisfying(equalTo(ATTR_DAEMON, true))
-                                    .hasValueSatisfying(v -> v.isPositive()))));
+                .satisfies(
+                    data ->
+                        assertThat(data.getLongSumData().getPoints())
+                            .anyMatch(point -> point.getValue() > 0 && !isDaemon(point))
+                            .anyMatch(point -> point.getValue() > 0 && isDaemon(point))));
+  }
+
+  private static boolean isDaemon(LongPointData point) {
+    return requireNonNull(point.getAttributes().get(ATTR_DAEMON));
   }
 }