Skip to content

Commit f62dbe6

Browse files
authored
Review fixes for mongo-3.1:library (open-telemetry#17538)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent f3e2856 commit f62dbe6

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/MongoTelemetryBuilder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
/** A builder of {@link MongoTelemetry}. */
1212
public final class MongoTelemetryBuilder {
1313

14-
// Visible for testing
15-
static final int DEFAULT_MAX_NORMALIZED_QUERY_LENGTH = 32 * 1024;
14+
private static final int DEFAULT_MAX_NORMALIZED_QUERY_LENGTH = 32 * 1024;
1615

1716
private final OpenTelemetry openTelemetry;
1817
private final String instrumentationName;

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoInstrumenterFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
*/
2020
public final class MongoInstrumenterFactory {
2121

22-
public static final int DEFAULT_MAX_NORMALIZED_QUERY_LENGTH = 32 * 1024;
22+
static final int DEFAULT_MAX_NORMALIZED_QUERY_LENGTH = 32 * 1024;
2323

2424
public static Instrumenter<CommandStartedEvent, Void> createInstrumenter(
2525
OpenTelemetry openTelemetry, String instrumentationName, boolean querySanitizationEnabled) {

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/StringBuilderWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void flush() {}
2727
@Override
2828
public void close() {}
2929

30-
public StringBuilder getBuilder() {
30+
StringBuilder getBuilder() {
3131
return sb;
3232
}
3333
}

instrumentation/mongo/mongo-3.1/library/src/test/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoDbAttributesGetterTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,12 @@ void shouldTruncateArray() {
9191
.isIn("{\"cmd\": \"c\", \"f1\": [\"?\", \"?", "{\"cmd\": \"c\", \"f1\": [\"?\",");
9292
}
9393

94-
static String sanitizeQueryAcrossVersions(MongoDbAttributesGetter extractor, BsonDocument query) {
94+
private static String sanitizeQueryAcrossVersions(
95+
MongoDbAttributesGetter extractor, BsonDocument query) {
9596
return sanitizeAcrossVersions(extractor.sanitizeQuery(query));
9697
}
9798

98-
static String sanitizeAcrossVersions(String json) {
99+
private static String sanitizeAcrossVersions(String json) {
99100
json = json.replaceAll("\\{ ", "{");
100101
json = json.replaceAll(" }", "}");
101102
json = json.replaceAll(" :", ":");

0 commit comments

Comments
 (0)