Skip to content

Commit f895502

Browse files
committed
Clean up VirtualField
1 parent 3a9292f commit f895502

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

instrumentation/netty/netty-3.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/server/HttpServerResponseTracingHandler.java

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import io.opentelemetry.instrumentation.netty.common.internal.NettyErrorHolder;
1414
import io.opentelemetry.javaagent.bootstrap.http.HttpServerResponseCustomizerHolder;
1515
import io.opentelemetry.javaagent.instrumentation.netty.v3_8.NettyRequest;
16+
import javax.annotation.Nullable;
1617
import org.jboss.netty.channel.Channel;
1718
import org.jboss.netty.channel.ChannelHandlerContext;
1819
import org.jboss.netty.channel.MessageEvent;
@@ -41,10 +42,20 @@ public void writeRequested(ChannelHandlerContext ctx, MessageEvent msg) throws E
4142
try (Scope ignored = context.makeCurrent()) {
4243
super.writeRequested(ctx, msg);
4344
} catch (Throwable t) {
44-
instrumenter().end(context, request, response, NettyErrorHolder.getOrDefault(context, t));
45+
end(ctx.getChannel(), context, request, response, t);
4546
throw t;
4647
}
47-
instrumenter().end(context, request, response, NettyErrorHolder.getOrDefault(context, null));
48+
end(ctx.getChannel(), context, request, response, null);
49+
}
50+
51+
private static void end(
52+
Channel channel,
53+
Context context,
54+
NettyRequest request,
55+
HttpResponse response,
56+
@Nullable Throwable error) {
57+
requestAndContextField.set(channel, null);
58+
instrumenter().end(context, request, response, NettyErrorHolder.getOrDefault(context, error));
4859
}
4960

5061
private static void customizeResponse(Context context, HttpResponse response) {

0 commit comments

Comments
 (0)