Review fixes for lettuce-5.1:javaagent (open-telemetry#18176)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>

Author: 3 people

instrumentation/lettuce/lettuce-5.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_1/ClientResourcesInstrumentation.java

@@ -40,8 +40,8 @@ public static class BuilderAdvice {
 
     @Advice.OnMethodExit(suppress = Throwable.class, inline = false)
     public static void onExit(@Advice.Return ClientResources.Builder builder) {
-      if (CompatibilityChecker.checkCompatible()) {
-        builder.tracing(TracingHolder.TRACING);
+      if (CompatibilityChecker.isCompatible()) {
+        builder.tracing(TracingHolder.tracing());
       }
     }
   }

instrumentation/lettuce/lettuce-5.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_1/CompatibilityChecker.java

@@ -9,9 +9,9 @@
 
 public class CompatibilityChecker {
 
-  private static final boolean isCompatible = isCompatible();
+  private static final boolean IS_COMPATIBLE = computeCompatibility();
 
-  private static boolean isCompatible() {
+  private static boolean computeCompatibility() {
     try {
       Tracing.getContext();
       return true;
@@ -23,8 +23,8 @@ private static boolean isCompatible() {
   // related to https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/10997
   // if users are using incompatible versions of reactor-core and lettuce
   // then just disable the instrumentation
-  public static boolean checkCompatible() {
-    return isCompatible;
+  public static boolean isCompatible() {
+    return IS_COMPATIBLE;
   }
 
   private CompatibilityChecker() {}

instrumentation/lettuce/lettuce-5.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_1/TracingHolder.java

@@ -18,13 +18,17 @@ public class TracingHolder {
           .get("command_encoding_events/development")
           .getBoolean("enabled", false);
 
-  public static final Tracing TRACING =
+  private static final Tracing tracing =
       LettuceTelemetry.builder(GlobalOpenTelemetry.get())
           .setQuerySanitizationEnabled(
               DbConfig.isQuerySanitizationEnabled(GlobalOpenTelemetry.get(), "lettuce"))
           .setEncodingSpanEventsEnabled(CAPTURE_COMMAND_ENCODING_EVENTS)
           .build()
           .createTracing();
 
+  public static Tracing tracing() {
+    return tracing;
+  }
+
   private TracingHolder() {}
 }