Skip to content

Reduce flakiness in GrpcTest.clientCallAfterServerCompleted() #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reduce flakiness in GrpcTest.clientCallAfterServerCompleted() #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ....6/testing/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/AbstractGrpcTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,12 +1508,16 @@ public void sayHello(

executor.execute(
() -> {
try {
backendStub.sayHello(request);
} catch (Throwable t) {
error.set(t);
}
clientCallDone.countDown();
// Execute in ROOT context to avoid cancelled context propagation
io.grpc.Context.ROOT.run(
() -> {
try {
backendStub.sayHello(request);
} catch (Throwable t) {
error.set(t);
}
clientCallDone.countDown();
});
});
}
}))
Expand All @@ -1533,7 +1537,9 @@ public void sayHello(
// for the two cases due to lack of context propagation in the library case, but that isn't what
// we're testing here.

clientCallDone.await(10, SECONDS);
assertThat(clientCallDone.await(10, SECONDS))
.as("client call should complete within timeout")
.isTrue();

assertThat(error).hasValue(null);
}
Expand Down