Skip to content

Add netlify --json flag option #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakubKoralewski wants to merge 4 commits into
base: master
Choose a base branch
from
+11 −2
Open

Add netlify --json flag option #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c771a7a
feat(netlify): json env variable
JakubKoralewski Aug 21, 2020
8b0a235
fix(netlify): allow capturing shell output from provider
JakubKoralewski Aug 21, 2020
c04cb32
fix(netlify): write to disk
JakubKoralewski Aug 21, 2020
d628996
shell (#1)
JakubKoralewski Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/dpl/providers/netlify.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,20 @@ class Netlify < Provider
opt '--functions FUNCS', 'Specify a functions folder to deploy'
opt '--message MSG', 'A message to include in the deploy log'
opt '--prod', 'Deploy to production'
opt '--json', 'Output json data'

def deploy
shell "netlify deploy #{deploy_opts}"
output = shell "netlify deploy #{deploy_opts}", echo: false, capture:true
info output
if json
shell "echo \"#{output.gsub(/\n/, '').gsub(/"/, '\"')}\" > ./NETLIFY_DEPLOY_JSON_ID_#{site}.json"
end
end

private

def deploy_opts
opts_for(%i(site auth dir functions message prod))
opts_for(%i(site auth dir functions message prod json))
end
end
end
Expand Down
4 changes: 4 additions & 0 deletions spec/dpl/providers/netlify_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
it { should have_run 'netlify deploy --site="id" --auth="token" --prod' }
end

describe 'given --json' do
it { should have_run 'netlify deploy --site="id" --auth="token" --json' }
end

describe 'with credentials in env vars', run: false do
let(:args) { %w(--site id) }
env NETLIFY_AUTH: 'token'
Expand Down