Update helmfile to latest and reorganize due to v1 breaking changes#72
Open
nocturo wants to merge 1 commit into
Open
Update helmfile to latest and reorganize due to v1 breaking changes#72nocturo wants to merge 1 commit into
nocturo wants to merge 1 commit into
Conversation
- Updates helmfile to latest - Add helm-v4 support - Updates usage for helmfile v1
Owner
|
Thanks for the assistance! Sorry for the delay getting back but this is on my radar to look at more closely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @travisghansen,
I took the liberty to update your awesome tool to support newer helmfile and be compatible with the 1.x branch as they've removed
--argsso there were couple of changes needed needed. Here is the overview of changes:HELM_TEMPLATE_OPTIONSashelmfiledoes not support passing it through--argsanymore.KUBE_API_VERSIONSashelmfiledoes not support passing it through--argsanymore.helmfileto the latest versionhelm-v4with the latest versionI would be grateful if you could review this and let me know if you have any additional comments that I can address before you merge this.