address yet more coderabbit feedback ..

Signed-off-by: Triona Doyle <tekton@example.com>

Author: Triona Doyle

test/ui-e2e/README.md

@@ -68,7 +68,7 @@ All executions are driven via the ./run-ui-tests.sh wrapper script. This wrapper
 | `--headed` | Launches the visible Chromium browser UI. Excellent for local debugging. |
 | `--trace on` | Records a granular execution trace (DOM snapshots, network calls, actions) for visual triage. |
 | `--reporter=list` | Switches stdout to a clean line-by-line format, ideal for monitoring real-time execution steps. |
-| `--env=<ci|pipeline>` | Overrides the local setup to simulate automation. It forces headless execution, performs a clean `npm ci`, and installs required browser binaries dynamically. |
+| --env=<ci\|pipeline> | Overrides the local setup to simulate automation. It forces headless execution, performs a clean `npm ci`, and installs required browser binaries dynamically. |
 
 ### Visual Debugging (Trace Viewer)
 

test/ui-e2e/global.setup.ts

@@ -13,9 +13,10 @@ async function globalSetup() {
     execSync('oc delete all -l app=spring-petclinic -n openshift-gitops --wait=false', { stdio: 'ignore' });
 
     console.log('* Cluster sanitized. Starting test suite.');
-  } catch (error) {
-    console.log('* Cluster is clean. Starting test suite.');
-  }
+    } catch (error) {
+    console.error('Pre-flight cleanup failed. Check your cluster connection.', error);
+    throw error;
+    }
 }
 
 export default globalSetup;

test/ui-e2e/run-ui-tests.sh

@@ -12,16 +12,16 @@ while [[ "$#" -gt 0 ]]; do
     shift
 done
 
+#making sure we are in the correct dir
+cd "$(dirname "$0")" || exit 1
+
 if [ -f .env ]; then
   echo "Loading variables from .env file..."
   set -a  #export all variables
   source .env
   set +a  #stop auto export
 fi
 
-#making sure we are in the correct dir
-cd "$(dirname "$0")" || exit 1
-
 #username (might be something different for rosa - can be overwritten with export CLUSTER_USER)
 export CLUSTER_USER=${CLUSTER_USER:-"kubeadmin"}
 export IDP=${IDP:-"kube:admin"}
@@ -67,18 +67,24 @@ rm -f .auth/storageState.json || true
 echo " Starting Playwright tests..."
 
 # 2. Execute based on the environment
-if [[ "$ENV" == "ci" ]] || [[ "$ENV" == "pipeline" ]]; then
+if [ "$ENV" = "ci" ] || [ "$ENV" = "pipeline" ]; then
     echo "Running headlessly in automation ($ENV)..."
     npm ci
-    
-    # Prevent sudo jump-scares for local Mac users simulating CI
-    if [[ "$(uname -s)" == "Darwin" ]]; then
+    if [ "$(uname -s)" = "Darwin" ]; then
         npx playwright install chromium
     else
         npx playwright install chromium --with-deps
     fi
 
-    npx playwright test "${TEST_ARGS[@]}" --reporter=list
+    #headed from args
+    FILTERED_ARGS=()
+    for arg in "${TEST_ARGS[@]}"; do
+        if [[ "$arg" != "--headed" ]]; then
+            FILTERED_ARGS+=("$arg")
+        fi
+    done
+    
+    npx playwright test "${FILTERED_ARGS[@]}" --reporter=list
 
 else
     echo "Running Locally..."

test/ui-e2e/src/pages/ApplicationDetailsPage.ts

@@ -23,7 +23,8 @@ export class ApplicationDetailsPage {
     //wait tree to be visible
     await expect(this.resourceTreeContainer).toBeVisible({ timeout: 20000 });
     //wait for healthy status
-    await expect(this.page.getByText('Healthy', { exact: true }).first()).toBeVisible({ timeout: 30000 });
+  await expect(this.resourceTreeContainer.getByText('Healthy', { exact: true }).first()).toBeVisible({ timeout: 30000 });  
+
   }
 
   async clickResourceNode(kind: string, name: string) {

test/ui-e2e/src/pages/ApplicationsPage.ts

@@ -128,9 +128,11 @@ export class ApplicationsPage {
 
     //now it is safe to open the panel
     await appContainer.getByText('Sync', { exact: true }).click();
+
+    const slideOutPanel = this.page.locator('.sliding-panel').filter({ visible: true });
 
-    //click 'all' first to ensure all resource checkboxes are ticked across newer Argo CD versions
-    const allLink = this.page.getByRole('link', { name: 'all', exact: true });
+    // 🚀 SWAPPED: this.page is now slideOutPanel
+    const allLink = slideOutPanel.getByRole('link', { name: 'all', exact: true });
     try {
       await allLink.waitFor({ state: 'visible', timeout: TIMEOUTS.modal });
       await allLink.click();
@@ -143,11 +145,11 @@ export class ApplicationsPage {
       }
     }
 
-    //wait for the manifests to render on the panel (generous timeout for slower FIPS clusters)
-    await expect(this.page.getByText(expectedResource).first()).toBeVisible({ timeout: TIMEOUTS.render });
+    // 🚀 SWAPPED: this.page is now slideOutPanel
+    await expect(slideOutPanel.getByText(expectedResource).first()).toBeVisible({ timeout: TIMEOUTS.render });
 
-    //click the main sync button
-    await this.page.getByRole('button', { name: /^synchronize$/i }).first().click();
+    // 🚀 SWAPPED: this.page is now slideOutPanel
+    await slideOutPanel.getByRole('button', { name: /^synchronize$/i }).first().click();
 
     //wait for the panel to close 
     await expect(this.page.getByText('SYNCHRONIZE RESOURCES')).toBeHidden({ timeout: TIMEOUTS.panel });
@@ -174,8 +176,8 @@ export class ApplicationsPage {
 
     //find the container, then specifically click the link of the app name
     const appLink = this.page.locator('.white-box, .argo-table-list__row')
-                             .filter({ hasText: appName })
-                             .getByRole('link', { name: appName });
+                         .filter({ has: this.page.getByText(appName, { exact: true }) })
+                         .getByRole('link', { name: appName, exact: true });
 
     await appLink.waitFor({ state: 'visible', timeout: TIMEOUTS.default });
     await appLink.click();